Infinite loop while trying to change payment method for subscription (5900) #4085
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing the Change Payment Method page for a subscription (via My Account > Subscriptions), an infinite loop is triggered, causing a crash or white screen.
Steps to reproduce
PR Changes
get_the_content()internally callsthe_title_attribute(), which applies thethe_titlefilter. When WooCommerce Subscriptions hooks that filter and calls is_checkout(), it triggers ourwoocommerce_is_checkouthandler, which calls back intofind_classic_shortcode_block()creating infinite recursion.This PR uses
get_post()->post_contentbypassing all filters, which is safe here since we only need the raw block markup.