This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Remove deprecated data controls in favour of those from the @wordpress/data package
#5574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
senadir
and removed request for
a team
mikejolley
added
status: needs review
type: cooldown
Contributor
|
Size Change: -14 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
mikejolley
requested review from
a team and
alexflorisca
and removed request for
a team and
senadir
alexflorisca
suggested changes
Feb 3, 2022
Contributor
alexflorisca
left a comment
alexflorisca
left a comment
There was a problem hiding this comment.
Hey @mikejolley, ran into an issue when testing this
The all products block seems to think there are no products (even though there definitely are)
Filter blocks alongside it also seem to be broken:
I don't know enough about how @wordpress/data works to suggest why this might be but I'm happy to help you figure it out!
The code looks good though and the Cart quantity selector seems to work fine ok and the tests pass 👍
| return Promise.resolve( '' ); | ||
| } ); | ||
| } ); | ||
| render( <CartBlock /> ); |
Contributor
There was a problem hiding this comment.
I think the render method should go inside the act() function from the react docs
mikejolley
force-pushed
the
fix/deprecated-data-controls
branch
from
b1a5d1e to
58a0383
Compare
Member
Author
|
I see the products issue too. I can't figure out why though 🤔 I don't see anything obvious in the diff which would break. I do see |
mikejolley
force-pushed
the
fix/deprecated-data-controls
branch
from
d2b34db to
c98c635
Compare
Member
Author
|
Found the issue. |
alexflorisca
approved these changes
Mar 9, 2022
Contributor
alexflorisca
left a comment
alexflorisca
left a comment
There was a problem hiding this comment.
Ah good spot. I wonder why there's 2 methods, from what I know select ran the resolver automatically if there was one specified and waited for it. Anyway good to go 👍
tjcafferkey
added
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes usage of the deprecated functions
selectanddispatchimported from@wordpress/data-controls(deprecated here) and replaces them withcontrols.selectandcontrols.dispatchfrom the@wordpress/datapackage.Fixes #5339
Questions from the issue:
The switch to
@wordpress/datahappened in Gutenberg 9.2, which was part of WordPress 5.6, but controls existed before then.Yes, it's part of schema and collections data-stores, used by All Products block.
The
controlsexport existed in WordPress 5.6 (see here). This is the min supported version of Woo core.Blocks min support is 5.8. Both are satisfied.
Testing
How to test the changes in this Pull Request:
JS tests must also pass. I removed the deprecation assertions from those.
Changelog