Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Jan 23, 2026

Closes WOOMOB-2023

Description

When multiple card readers are found, the UI now shows a scanning indicator to indicate that discovery is still ongoing. Also improves the description copy from "Select a reader to connect" to "Choose a reader".

Changes:

  • Add spinning progress indicator below the reader list
  • Update description copy to "Choose a reader"
  • Update preview to use full dialog wrapper

Test Steps

  1. Go to WooPos and trigger card reader connection
  2. Have multiple readers nearby and turned on (or just simulator)
  3. Observe the "Multiple readers found" dialog
  4. Verify the spinning indicator appears below the reader list
  5. Verify the description says "Choose a reader"

Images/gif

01-23--13-57.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@kidinov kidinov added this to the 24.1 milestone Jan 23, 2026
@kidinov kidinov requested a review from malinajirka January 23, 2026 13:02
@kidinov kidinov marked this pull request as ready for review January 23, 2026 13:02
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit23cacd3
Direct Downloadwoocommerce-wear-prototype-build-pr15246-23cacd3.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit23cacd3
Direct Downloadwoocommerce-prototype-build-pr15246-23cacd3.apk

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.20%. Comparing base (b5e5f3b) to head (23cacd3).

Files with missing lines Patch % Lines
...der/connection/WooPosCardReaderConnectionDialog.kt 0.00% 23 Missing ⚠️
Additional details and impacted files
@@                                Coverage Diff                                 @@
##             woomob-1854-woopos-card-reader-connection-ui   #15246      +/-   ##
==================================================================================
- Coverage                                           38.20%   38.20%   -0.01%     
  Complexity                                          10570    10570              
==================================================================================
  Files                                                2197     2197              
  Lines                                              126520   126533      +13     
  Branches                                            17577    17577              
==================================================================================
- Hits                                                48337    48336       -1     
- Misses                                              73278    73292      +14     
  Partials                                             4905     4905              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants