Skip to content

Conversation

@ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Jan 23, 2026

(Partially) Closes: AINFRA-1781


Description

Remove unused mediapicker path configurations and add the missing source-camera substitution for local development builds.

Context: The Tenor API is being sunset on June 30, 2026. The source-gif module in the Media Picker library relies on Tenor for GIF search functionality. Since this project doesn't use the source-gif module (or source-device and domain), we're removing these unused dependency substitution configurations to avoid misconfiguration, or using the (to be) deprecated source-gif module.

tenor-deprecation

Changes:

  • Remove unused gradle extension properties:
    • mediaPickerDomainBinaryPath
    • mediaPickerSourceDeviceBinaryPath
    • mediaPickerSourceGifBinaryPath
  • Add missing mediaPickerSourceCameraBinaryPath substitution to include_builds.gradle.

Test Steps

Normal Builds

  1. Verify the project builds successfully.
  2. Verify you can upload a product photo with either of the 3 methods available:
    • Choose from device
    • Take a photo
    • WordPress media library

Local Builds

  1. Create a local-builds.gradle file with localMediaPickerPath pointing to a local Media Picker checkout.
  2. Sync Gradle and verify the substitution message appears.
    • FYI: On Media Picker, you will need to update agpVersion version to 8.13.2 and match the AGP version of WCAndroid.
  3. Verify the project builds successfully.
  4. Verify you can upload a product photo with either of the 3 methods available:
    • Choose from device
    • Take a photo
    • WordPress media library

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

ParaskP7 and others added 2 commits January 23, 2026 12:28
Remove unused gradle extension properties for mediapicker
dependencies that are no longer used in the project:
- mediaPickerDomainBinaryPath
- mediaPickerSourceDeviceBinaryPath
- mediaPickerSourceGifBinaryPath

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add mediaPickerSourceCameraBinaryPath to include_builds.gradle
for local development substitution.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ParaskP7 ParaskP7 added this to the 24.1 milestone Jan 23, 2026
@ParaskP7 ParaskP7 requested a review from Copilot January 23, 2026 11:30
@ParaskP7 ParaskP7 added category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. type: technical debt Represents or solves tech debt of the project. Core dependencies Pull requests that update a dependency file labels Jan 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up unused Media Picker local-build substitution settings and ensures the camera source module is correctly wired for local development. It specifically aligns Gradle configuration with the subset of Media Picker modules actually used by the app, avoiding future misconfigurations around deprecated GIF support.

Changes:

  • Removed unused Gradle ext properties for mediapicker domain, source-device, and source-gif binaries from settings.gradle.
  • Ensured only the mediapicker core and source-camera binary coordinates are defined as Gradle ext properties.
  • Updated include_builds.gradle to substitute the source-camera module when using a local Media Picker build, matching the existing implementation dependency in WooCommerce/build.gradle.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
settings.gradle Removes unused Media Picker binary path properties and keeps only the core and source-camera module coordinates, which are the ones actually used.
config/gradle/include_builds.gradle Updates the local-build substitution to include the source-camera project alongside the main mediapicker project, so local Media Picker builds correctly replace both binary dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit51b31b3
Direct Downloadwoocommerce-wear-prototype-build-pr15243-51b31b3.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit51b31b3
Direct Downloadwoocommerce-prototype-build-pr15243-51b31b3.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. Core dependencies Pull requests that update a dependency file type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants