-
Notifications
You must be signed in to change notification settings - Fork 138
[Build] Clean Up mediapicker Local Build Substitutions
#15243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[Build] Clean Up mediapicker Local Build Substitutions
#15243
Conversation
Remove unused gradle extension properties for mediapicker dependencies that are no longer used in the project: - mediaPickerDomainBinaryPath - mediaPickerSourceDeviceBinaryPath - mediaPickerSourceGifBinaryPath Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add mediaPickerSourceCameraBinaryPath to include_builds.gradle for local development substitution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR cleans up unused Media Picker local-build substitution settings and ensures the camera source module is correctly wired for local development. It specifically aligns Gradle configuration with the subset of Media Picker modules actually used by the app, avoiding future misconfigurations around deprecated GIF support.
Changes:
- Removed unused Gradle
extproperties formediapickerdomain, source-device, and source-gif binaries fromsettings.gradle. - Ensured only the
mediapickercore andsource-camerabinary coordinates are defined as Gradleextproperties. - Updated
include_builds.gradleto substitute thesource-cameramodule when using a local Media Picker build, matching the existingimplementationdependency inWooCommerce/build.gradle.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
settings.gradle |
Removes unused Media Picker binary path properties and keeps only the core and source-camera module coordinates, which are the ones actually used. |
config/gradle/include_builds.gradle |
Updates the local-build substitution to include the source-camera project alongside the main mediapicker project, so local Media Picker builds correctly replace both binary dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
(Partially) Closes: AINFRA-1781
Description
Remove unused
mediapickerpath configurations and add the missingsource-camerasubstitution for local development builds.Context: The Tenor API is being sunset on June 30, 2026. The
source-gifmodule in theMedia Pickerlibrary relies on Tenor for GIF search functionality. Since this project doesn't use thesource-gifmodule (orsource-deviceanddomain), we're removing these unused dependency substitution configurations to avoid misconfiguration, or using the (to be) deprecatedsource-gifmodule.Changes:
mediaPickerDomainBinaryPathmediaPickerSourceDeviceBinaryPathmediaPickerSourceGifBinaryPathmediaPickerSourceCameraBinaryPathsubstitution toinclude_builds.gradle.Test Steps
Normal Builds
Choose from deviceTake a photoWordPress media libraryLocal Builds
local-builds.gradlefile withlocalMediaPickerPathpointing to a localMedia Pickercheckout.FYI: OnMedia Picker, you will need to updateagpVersionversion to8.13.2and match the AGP version of WCAndroid.Choose from deviceTake a photoWordPress media libraryRELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.