[WOOMOB-2022] Add consistent close button and padding to POS dialogs #15241
+165
−228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add onCloseClick parameter to display a consistent close button - Add XLarge padding to dialog content for consistency - Update dialogs to use wrapper's close button and remove redundant padding
Add ScanningSetupDialogPreviewWrapper to show previews with the dialog wrapper and close button for consistent preview experience.
Collaborator
Generated by 🚫 Danger |
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #15241 +/- ##
=========================================
Coverage 38.71% 38.72%
Complexity 10563 10563
=========================================
Files 2194 2194
Lines 124987 124960 -27
Branches 17299 17310 +11
=========================================
- Hits 48389 48387 -2
+ Misses 71705 71680 -25
Partials 4893 4893 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: WOOMOB-2022
Description
This PR introduces a unified approach to close buttons and content padding in POS dialogs to ensure visual consistency across all dialog components.
Changes:
onCloseClickparameter toWooPosDialogWrapper- when provided, displays a standardized close button (40dp icon with 0.6f alpha tint) at the top-rightWooPosScanningSetupDialogpreviews to use the dialog wrapper for accurate preview renderingThis ensures all POS dialogs have the same close button appearance and spacing, making it easier to maintain consistency as new dialogs are added.
@samiuelson I didn't touch the refund dialog as it is for some reason completely different from the rest of the dialogs, but if we still keep that in the dialog, I'd suggest strongly reconsidering and to follow the same pattern everywhere. I am fine with changing the look for all the rest of the dialogs as well, but it will still be much easier to do if we reuse the same component.
@malinajirka I will take these changes to the feature branch with the card reader connection flow so they will be applied there as well
Test Steps
Images/gif
(PREVIEWS)
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.