Add push notification tracking for Milestone 1 #15239

irfano · 2026-01-22T19:52:48Z

Description

Implements Milestone 1 push notification tracking as outlined in the pe5sF9-4Xn-p2.

New Events:

woo_push_token_register_success - Tracked when Woo Core push token registration succeeds
woo_push_token_register_error - Tracked when registration fails, includes error details
wpcom_device_disable_push_notifications_success - Tracked when WPCOM notifications are disabled*
wpcom_device_disable_push_notifications_error - Tracked when disabling fails*

I didn't add disable events to the site list screen because it updates all sites in a single API call and already tracks specific success and error events.

Updated Events:

push_notification_received - Added common properties (is_jetpack_installed, is_jetpack_connected, is_jetpack_cp_connected, is_ciab, garden_partner
)
push_notification_tapped - Added common properties

Refactoring:

NotificationAnalyticsTracker now uses siteId parameter instead of SiteModel
Added trackError() method for error event tracking with error details
Removed SiteStore dependency from NotificationMessageHandler

Test Steps

1. Test `woo_push_token_register_success`

Preconditions:

A test site with WooCommerce 10.4.0-dev (supports Woo Core push endpoint)
Feature flag WOO_PUSH_NOTIFICATIONS_SYSTEM enabled

Steps:

Build the app with feature flag enabled
Login to a site with WooCommerce 10.4.0-dev.
Check logcat for the event.

Verify:
woocommerceandroid_woo_push_token_register_success Properties: is_jetpack_installed, is_jetpack_connected, is_jetpack_cp_connected, is_ciab, garden_partner.

2. Test `woo_push_token_register_error`

Preconditions:

A test site with WooCommerce version below 10.4.3 (no push endpoint support)
Feature flag WOO_PUSH_NOTIFICATIONS_SYSTEM enabled

Steps:

Build the app with feature flag enabled.
Login to the site.
Check logcat for the event.

Verify:
woocommerceandroid_woo_push_token_register_error Properties: is_jetpack_installed, is_jetpack_connected, is_jetpack_cp_connected, is_ciab, garden_partner, error_description, error_type, error_code.

3. Test `wpcom_device_disable_push_notifications_success`

Preconditions:

A test site with WooCommerce 10.4.0-dev
Previously logged in with feature flag disabled (WPCOM device registered)

Steps:

Build the app with feature flag disabled.
Login to a site (this registers WPCOM device).
Enable feature flag and rebuild the app.
Login to the same site again.
Check logcat for the event.

Verify:
woocommerceandroid_wpcom_device_disable_push_notifications_success Properties: is_jetpack_installed, is_jetpack_connected, is_jetpack_cp_connected, is_ciab, garden_partner.

4. Test `wpcom_device_disable_push_notifications_error`

Preconditions:

Fresh install or WPCOM device was never registered

Steps:

Fresh install the app with feature flag enabled
Login to a site with WooCommerce 10.4+
Check logcat for the event.

Verify:
woocommerceandroid_wpcom_device_disable_push_notifications_error Properties: error_description ("Device not registered."), error_type ("UnregisteredDevice"), is_jetpack_installed, is_jetpack_connected, is_jetpack_cp_connected, is_ciab, garden_partner.

5. Test `push_notification_received`

Preconditions:

Push notifications enabled for the site
Push notification permissions granted

Steps:

Login to a site with push notifications enabled.
Trigger a notification (e.g., create a product review from another device/browser)
Receive the push notification
Check logcat for the event

Verify:
woocommerceandroid_push_notification_received Properties: is_jetpack_installed, is_jetpack_connected, is_jetpack_cp_connected, is_ciab, garden_partner

6. Test `push_notification_tapped`

Preconditions:

A push notification is displayed

Steps:

Receive a push notification (see step 5)
Tap on the notification
Check logcat for the event

Verify:
woocommerceandroid_push_notification_tapped: Properties: is_jetpack_installed, is_jetpack_connected, is_jetpack_cp_connected, is_ciab, garden_partner

Images/gif

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

dangermattic · 2026-01-22T19:53:32Z

	1 Error
🚫	PR is not assigned to a milestone.

	1 Message
📖	This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed: The tracks events must be validated in the Tracks system. Verify the internal Tracks spreadsheet has also been updated. Please consider registering any new events. The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

wpmobilebot · 2026-01-22T20:04:43Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`017ea6e`
	Direct Download	`woocommerce-wear-prototype-build-pr15239-017ea6e.apk`

wpmobilebot · 2026-01-22T20:15:11Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`017ea6e`
	Direct Download	`woocommerce-prototype-build-pr15239-017ea6e.apk`

wpmobilebot · 2026-01-22T20:37:33Z

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

JorgeMucientes

Nicely done @irfano.
Tracking works as expected, however I left a suggestion that might be worth checking, as that would expand the support for common properties to the rest of the tracking events.
Also, it would be a nice opportunity to do some legacy properties clean up.

JorgeMucientes · 2026-01-23T17:50:13Z

...e/src/main/kotlin/com/woocommerce/android/notifications/push/NotificationAnalyticsTracker.kt

+        this["is_jetpack_installed"] = site.isJetpackInstalled
+        this["is_jetpack_connected"] = site.isJetpackConnected
+        this["is_jetpack_cp_connected"] = site.isJetpackCPConnected
+        this["is_ciab"] = site.isCIABSite()


Suggestion.
I think we could set this properties in AnalyticsTracker.ktclass instead. In particular inbuildFinalProperties()function. This goes in line with what was suggeted in the P2 tracking plan comments. At the very least I'd addis_ciabandgarden_partnerthere. And while you are at it, remove the propertyfinalProperties[KEY_WAS_ECOMMERCE_TRIAL] = it.wasEcommerceTrial` from there. It doesn't make sense to track that anymore.

JorgeMucientes · 2026-01-23T17:55:37Z

...e/src/main/kotlin/com/woocommerce/android/notifications/push/NotificationAnalyticsTracker.kt

+        this["is_jetpack_connected"] = site.isJetpackConnected
+        this["is_jetpack_cp_connected"] = site.isJetpackCPConnected
+        this["is_ciab"] = site.isCIABSite()
+        site.gardenPartner?.let { this["garden_partner"] = it }


I haven't checked the API response yet, but in all my tests garde_partner was always null. I wonder if they have removed this field from the site model. I wouldn't be surprised tbh

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

irfano added 5 commits January 22, 2026 22:10

Add common properties for notification events

8b56d91

Track woo_push_token_register_success

17780d3

Track woo_push_token_register_error

dd52d1c

Track wpcom_device_disable_push_notifications_success

b4a7871

Track wpcom_device_disable_push_notifications_error

017ea6e

irfano requested a review from JorgeMucientes January 22, 2026 19:52

irfano added category: tracks Related to analytics, including Tracks Events. feature: notifications Related to notifications or notifs. labels Jan 22, 2026

JorgeMucientes self-assigned this Jan 23, 2026

JorgeMucientes requested a review from Copilot January 23, 2026 17:29

Copilot started reviewing on behalf of JorgeMucientes January 23, 2026 17:29 View session

JorgeMucientes approved these changes Jan 23, 2026

View reviewed changes

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add push notification tracking for Milestone 1 #15239

Add push notification tracking for Milestone 1 #15239

irfano commented Jan 22, 2026

Uh oh!

dangermattic commented Jan 22, 2026

Uh oh!

wpmobilebot commented Jan 22, 2026

Uh oh!

wpmobilebot commented Jan 22, 2026

Uh oh!

wpmobilebot commented Jan 22, 2026

Uh oh!

JorgeMucientes left a comment

Uh oh!

JorgeMucientes Jan 23, 2026

Uh oh!

JorgeMucientes Jan 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add push notification tracking for Milestone 1 #15239

Are you sure you want to change the base?

Add push notification tracking for Milestone 1 #15239

Conversation

irfano commented Jan 22, 2026

Description

Test Steps

1. Test woo_push_token_register_success

2. Test woo_push_token_register_error

3. Test wpcom_device_disable_push_notifications_success

4. Test wpcom_device_disable_push_notifications_error

5. Test push_notification_received

6. Test push_notification_tapped

Images/gif

Uh oh!

dangermattic commented Jan 22, 2026

Uh oh!

wpmobilebot commented Jan 22, 2026

Uh oh!

wpmobilebot commented Jan 22, 2026

Uh oh!

wpmobilebot commented Jan 22, 2026

🤖 Build Failure Analysis

Uh oh!

JorgeMucientes left a comment

Choose a reason for hiding this comment

Uh oh!

JorgeMucientes Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

JorgeMucientes Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

1. Test `woo_push_token_register_success`

2. Test `woo_push_token_register_error`

3. Test `wpcom_device_disable_push_notifications_success`

4. Test `wpcom_device_disable_push_notifications_error`

5. Test `push_notification_received`

6. Test `push_notification_tapped`