-
Notifications
You must be signed in to change notification settings - Fork 138
Replace Jetpack banner with a WP dashboard card UI #15180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Replace Jetpack banner with a WP dashboard card UI #15180
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
| import androidx.compose.foundation.layout.padding | ||
| import androidx.compose.foundation.layout.width | ||
| import androidx.compose.foundation.shape.RoundedCornerShape | ||
| import androidx.compose.material.MaterialTheme |
Check warning
Code scanning / Android Lint
material and material3 are separate, incompatible design system libraries Warning
| import androidx.compose.foundation.layout.width | ||
| import androidx.compose.foundation.shape.RoundedCornerShape | ||
| import androidx.compose.material.MaterialTheme | ||
| import androidx.compose.material.Text |
Check warning
Code scanning / Android Lint
material and material3 are separate, incompatible design system libraries Warning
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #15180 +/- ##
============================================
- Coverage 38.68% 38.66% -0.02%
Complexity 10546 10546
============================================
Files 2195 2197 +2
Lines 124922 124983 +61
Branches 17283 17292 +9
============================================
+ Hits 48322 48328 +6
- Misses 71711 71766 +55
Partials 4889 4889 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…th-wp-dashboard-card-ui # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt
Generated by 🚫 Danger |
|
Version |
Closes WOOMOB-1921
Description
Adds a new "Never miss a new order" dashboard card that prompts users to connect their store to WordPress.com for push notifications. The card is implemented as a configurable widget that can be hidden and reordered via the Customize screen.
The card is currently gated behind FeatureFlag.WOO_PUSH_NOTIFICATIONS_SYSTEM and will be shown when the flag is enabled. The onClick action is currently a no-op and will be implemented in a follow-up PR.
Test Steps
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.