Merge pull request #280 from wmde/no-pd-on-edited

Dont show public domain snippet when image was edited
wmde · Jan 15, 2018 · 19634e3 · 19634e3
2 parents e7bce6c + 4568c75
commit 19634e3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/js/app/DialogueEvaluation.js b/js/app/DialogueEvaluation.js
@@ -136,7 +136,7 @@ $.extend( DialogueEvaluation.prototype, {
 		var url = this.getAttributionLicence().getUrl();
 		if( url ) {
 			attribution += ', ';
-			if( licence.isPublicDomain() ) {
+			if( !editingAttribution && licence.isPublicDomain() ) {
 				attribution += Messages.t( 'dialogue.pd-attribution-hint' )
 				+ ', ' + Messages.t( 'dialogue.check-details' )
 				+ ' Wikimedia Commons: ';
@@ -150,18 +150,18 @@ $.extend( DialogueEvaluation.prototype, {
 	_getHtmlAttribution: function() {
 		var attributionLink;
 		var licence = this.getAttributionLicence();
-		if( licence.isPublicDomain() ) {
+		var editingAttribution = this._getEditingAttribution();
+
+		if( !editingAttribution && licence.isPublicDomain() ) {
 			attributionLink = ', ' + Messages.t( 'dialogue.pd-attribution-hint' );
 			if( licence.getUrl() ) {
 				attributionLink += ', ' + Messages.t( 'dialogue.check-details' ) + ' '
 					+ this._makeLink( licence.getUrl(), 'Wikimedia Commons' );
 			}
 		} else {
 			attributionLink = ', ' + this._getHtmlLicence();
-			// attributionLink = this._getHtmlLicence();
 		}
 
-		var editingAttribution = this._getEditingAttribution();
 		if( editingAttribution ) {
 			editingAttribution = ', ' + editingAttribution;
 		}