-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
CI: Discover and build with usermod envs - 0.16 #5835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16_x
Are you sure you want to change the base?
Changes from 5 commits
0e5b4c4
a6fbf38
e10fa37
502a1e5
3ff8afc
37e7de3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # CI sample override file: this usermod has dependencies. | ||
| # Based on the CI standard but adds the Temperature usermod too. | ||
|
|
||
| [platformio] | ||
| default_envs = usermods_esp32, usermods_esp32c3, usermods_esp32s2, usermods_esp32s3 | ||
|
|
||
| [env:usermods_esp32] | ||
| extends = env:esp32dev | ||
| custom_usermods = ${usermods.custom_usermods} | ||
| board_build.partitions = ${esp32.extreme_partitions} ; We're gonna need a bigger boat | ||
| build_flags = ${env:esp32dev.build_flags} -D WLED_DEBUG | ||
|
|
||
|
|
||
| [env:usermods_esp32c3] | ||
| extends = env:esp32c3dev | ||
| board = esp32-c3-devkitm-1 | ||
| custom_usermods = ${usermods.custom_usermods} | ||
| board_build.partitions = ${esp32.extreme_partitions} ; We're gonna need a bigger boat | ||
| build_flags = ${env:esp32c3dev.build_flags} -D WLED_DEBUG | ||
|
|
||
|
|
||
| [env:usermods_esp32s2] | ||
| extends = env:lolin_s2_mini | ||
| custom_usermods = ${usermods.custom_usermods} | ||
| board_build.partitions = ${esp32.extreme_partitions} ; We're gonna need a bigger boat | ||
| build_flags = ${env:lolin_s2_mini.build_flags} -D WLED_DEBUG | ||
|
|
||
|
|
||
| [env:usermods_esp32s3] | ||
| extends = env:esp32s3dev_16MB_opi | ||
| custom_usermods = ${usermods.custom_usermods} | ||
| board_build.partitions = ${esp32.extreme_partitions} ; We're gonna need a bigger boat | ||
| build_flags = ${env:esp32s3dev_16MB_opi.build_flags} -D WLED_DEBUG | ||
|
|
||
|
|
||
| [usermods] | ||
| custom_usermods = PWM_fan | ||
| Temperature |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,16 +1,16 @@ | ||||||
| ; Options | ||||||
| ; ------- | ||||||
| ; USERMOD_SN_PHOTORESISTOR - define this to have this user mod included wled00\usermods_list.cpp | ||||||
| ; USERMOD_SN_PHOTORESISTOR_MEASUREMENT_INTERVAL - the number of milliseconds between measurements, defaults to 60 seconds | ||||||
| ; USERMOD_SN_PHOTORESISTOR_FIRST_MEASUREMENT_AT - the number of milliseconds after boot to take first measurement, defaults to 20 seconds | ||||||
| ; USERMOD_SN_PHOTORESISTOR_REFERENCE_VOLTAGE - the voltage supplied to the sensor, defaults to 5v | ||||||
| ; USERMOD_SN_PHOTORESISTOR_ADC_PRECISION - the ADC precision is the number of distinguishable ADC inputs, defaults to 1024.0 (10 bits) | ||||||
| ; USERMOD_SN_PHOTORESISTOR_RESISTOR_VALUE - the resistor size, defaults to 10000.0 (10K hms) | ||||||
| ; USERMOD_SN_PHOTORESISTOR_OFFSET_VALUE - the offset value to report on, defaults to 25 | ||||||
| ; | ||||||
| [env:usermod_sn_photoresistor_d1_mini] | ||||||
| extends = env:d1_mini | ||||||
| [env:usermod_sn_photoresistor_esp8266_2m] | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Update the documented environment name.
🤖 Prompt for AI Agents |
||||||
| extends = env:esp8266_2m | ||||||
| custom_usermods = ${env:esp8266_2m.custom_usermods} SN_Photoresistor | ||||||
| build_flags = | ||||||
| ${common.build_flags_esp8266} | ||||||
| -D USERMOD_SN_PHOTORESISTOR | ||||||
| lib_deps = ${env.lib_deps} | ||||||
| ${env:esp8266_2m.build_flags} | ||||||
| -D USERMOD_SN_PHOTORESISTOR_MEASUREMENT_INTERVAL=60 | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Use milliseconds for the measurement interval. The sample documents this option as milliseconds and describes 60 seconds as the intended interval. The value Proposed fix- -D USERMOD_SN_PHOTORESISTOR_MEASUREMENT_INTERVAL=60
+ -D USERMOD_SN_PHOTORESISTOR_MEASUREMENT_INTERVAL=60000📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| lib_deps = ${env:esp8266_2m.lib_deps} | ||||||
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Enable validation for all pull requests and pushes.
The workflow triggers on
pull_requestandpushchanges underusermods/**, butget_usermod_envsruns only for fork pull requests. Same-repository pull requests and pushes skip it, andbuildskips for the same reason. For pushes, use a push-specific matrix discovery path becausegithub.event.pull_request.base.shais unavailable.🧰 Tools
🪛 zizmor (1.29.0)
[warning] 1-116: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
[warning] 16-58: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
🤖 Prompt for AI Agents