-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Added new effect usermod - Diffusion Fire #4473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks for contributing! |
The particle system seems to be a bit heavy. Is it even possible to compile it on 4MB ESP32? My effect is just a simple usermod, so I think it's independent/complementary to the particle system. |
Okay, I managed to compile and flash the particle system branch and I think that my fire effect is different enough to warrant a merge, especially when it's a usermod, so conditionally compiled. |
The reason I did not yet approve this is the following: |
Okay, I renamed to |
thanks!
|
- use hw_random8 instead of random8 - changed diffusion calculation to fixed point math - adjusted general code formatting
Done. |
@mryndzionek if you want this merged, please update. |
No, I think we can close this. The new particle system subsumes this. |
@mryndzionek I would suggest you modify this PR to add this into usermod_example as an example for other people how to write custom effects. |
What do you mean by that exactly? Something more than resolving the conflicts? |
Modify this PR so that it changes usermods/EXAMPLE_v2/usermod_v2_example.cpp (or .h) instead of creating a new usermod. |
Where is changes |
I pushed #4667. Compiles on |
usermods/EXAMPLE/usermod_v2_example.cpp |
Usermod adding new fire effect. Has more parameters than other fire effects and can be widely adjusted/tweaked to look good even on small matrices.
