Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyarrow_bindings #405

Closed
wants to merge 4 commits into from
Closed

Conversation

maximiliank
Copy link
Contributor

Adding type caster for pyarrow bindings

Added additional tests
Installing pyarrow in ci workflow
Split Table, RecordBatch and Field/Schema bindings into separate headers
@wjakob
Copy link
Owner

wjakob commented Jan 17, 2024

Dear @maximiliank,

while I appreciate the significant effort that must have gone into this, I don't think this a component that needs to be part of nanobind (of which I try to keep the core as small as possible). My suggestion would be that you set up a separate repository. The nanobind documentation could then link to this repository and include a sort of directory of repositories with additional type casters.

Best,
WEnzel

@wjakob wjakob closed this Jan 17, 2024
@maximiliank
Copy link
Contributor Author

Dear @wjakob

thank you for your suggestion. I created a separate repository https://github.com/maximiliank/nanobind_pyarrow

Best,
Max

@wjakob
Copy link
Owner

wjakob commented Jan 25, 2024

I added a commit referencing your repository from the documentation just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants