Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for zero length array warning and gcc #347

Closed
wants to merge 7 commits into from
Closed

Fix for zero length array warning and gcc #347

wants to merge 7 commits into from

Conversation

garth-wells
Copy link
Contributor

GCC doesn't have "-Wzero-length-array" (unlike clang) [1], which caused #345. This change allows -Werror -pedantic builds with GCC and clang.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94428

@wjakob
Copy link
Owner

wjakob commented Oct 29, 2023

Sorry, I really don't like this change. You could alternatively realize it in your project by putting those pragmas around

#include <nanobind/nanobind.h>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants