Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Kotlin autolinker for React Native 0.63.x+ #7944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add Kotlin autolinker for React Native 0.63.x+ #7944

wants to merge 1 commit into from

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Dec 3, 2024 •
edited
Loading

Issue: #7821, #7943

Script was tested on: 0.72, 0.73, 0.74, 0.75, 0.76

To test:

npx @react-native-community/cli init Rn74 --version 0.74
cd Rn74
yarn add react-native-navigation@https://github.com/retyui/react-native-navigation.git#feat/retyui/add-kotlin-autolinker
npx rnn-link
Screenshot 2024-12-03 at 13 41 49

@retyui retyui force-pushed the feat/retyui/add-kotlin-autolinker branch 2 times, most recently from a1c0357 to d924541 Compare December 3, 2024 12:40
@retyui retyui mentioned this pull request Dec 3, 2024
Open
3 tasks
@retyui retyui marked this pull request as ready for review December 3, 2024 12:57
@retyui retyui force-pushed the feat/retyui/add-kotlin-autolinker branch 2 times, most recently from 544ea7f to e812b19 Compare December 3, 2024 13:34
@gosha212
Copy link
Contributor

gosha212 commented Dec 4, 2024

Great work @retyui. Can you add tests to the new use cases please? We will make the full review latter

@retyui retyui force-pushed the feat/retyui/add-kotlin-autolinker branch from e812b19 to 9746326 Compare December 4, 2024 10:31
@retyui
Copy link
Contributor Author

retyui commented Dec 4, 2024

@gosha212 I added test cases for new Kotlin files in RN 0.73, and happy that old tests cases wasn't affected (no breaking changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rautram100 rautram100 rautram100 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Kotlin Kotlin related stuff type: accepted/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@retyui @gosha212 @rautram100