Skip to content

Conversation

Kenzo-Wada
Copy link
Contributor

@Kenzo-Wada Kenzo-Wada commented Oct 11, 2025

Description

added japanese translation for /guide/route-data

related: #3463 (fixes broken links)

@Copilot Copilot AI review requested due to automatic review settings October 11, 2025 06:55
Copy link

changeset-bot bot commented Oct 11, 2025

⚠️ No Changeset found

Latest commit: ba1f7e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 11, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit ba1f7e5
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/68f3848ee58b3800082a93ff
😎 Deploy Preview https://deploy-preview-3462--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Oct 11, 2025
Copilot

This comment was marked as spam.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 11, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ja guides/route-data.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

HiDeoo
HiDeoo previously requested changes Oct 12, 2025
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I left a few suggestions to translate some titles but otherwise, everything looks great to me.


3. `onRequest` 関数を更新してルートデータを変更します。

ミドルウェアが最初に受け取る引数は [Astro の `context` オブジェクト](https://docs.astro.build/en/reference/api-reference/) です。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ミドルウェアが最初に受け取る引数は [Astro の `context` オブジェクト](https://docs.astro.build/en/reference/api-reference/) です。
ミドルウェアが最初に受け取る引数は [Astro の `context` オブジェクト](https://docs.astro.build/ja/reference/api-reference/) です。

We can link to the Japanese version of the Astro Docs here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: b05eacc

export default defineConfig({
integrations: [
starlight({
title: 'My delightful docs site',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably translate this title for consistency with most of other examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: ba1f7e5

export default defineConfig({
integrations: [
starlight({
title: 'My site with multiple middleware',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here regarding the title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: ba1f7e5

@Kenzo-Wada Kenzo-Wada requested a review from HiDeoo October 18, 2025 12:15
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the translation @Kenzo-Wada! And thanks to @HiDeoo for giving this a careful review 🙏

@delucis delucis dismissed HiDeoo’s stale review October 18, 2025 14:59

Changes made!

@delucis delucis merged commit 537631b into withastro:main Oct 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants