-
-
Notifications
You must be signed in to change notification settings - Fork 810
i18n(ja): added translation for route-data
#3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation 🙌
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I left a few suggestions to translate some titles but otherwise, everything looks great to me.
|
||
3. `onRequest` 関数を更新してルートデータを変更します。 | ||
|
||
ミドルウェアが最初に受け取る引数は [Astro の `context` オブジェクト](https://docs.astro.build/en/reference/api-reference/) です。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ミドルウェアが最初に受け取る引数は [Astro の `context` オブジェクト](https://docs.astro.build/en/reference/api-reference/) です。 | |
ミドルウェアが最初に受け取る引数は [Astro の `context` オブジェクト](https://docs.astro.build/ja/reference/api-reference/) です。 |
We can link to the Japanese version of the Astro Docs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed: b05eacc
export default defineConfig({ | ||
integrations: [ | ||
starlight({ | ||
title: 'My delightful docs site', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably translate this title for consistency with most of other examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed: ba1f7e5
export default defineConfig({ | ||
integrations: [ | ||
starlight({ | ||
title: 'My site with multiple middleware', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here regarding the title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed: ba1f7e5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the translation @Kenzo-Wada! And thanks to @HiDeoo for giving this a careful review 🙏
Description
added japanese translation for
/guide/route-data
related: #3463 (fixes broken links)