Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlarge header icons #2661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

illright
Copy link

@illright illright commented Dec 7, 2024

Description

Related to #1701, but not explicitly proposed there. The original proposal suggests to increase the space between the social icons, but I believe the icons themselves should be larger too.

This PR changes the appearance of social icons and the icons in language/theme selects to be larger. It also increases the touch area of the social icons to align it with the touch area of selects (~44.5px on desktop, ~48px on mobile). Finally, it marginally increases the space between the icon and the label, just something that's been bugging me visually a little bit.

Screenshots

Desktop (light)

BeforeAfter
Scherm­afbeelding 2024-12-07 om 19 22 40 Scherm­afbeelding 2024-12-07 om 19 23 17

Desktop (dark)

BeforeAfter
Scherm­afbeelding 2024-12-07 om 19 22 46 Scherm­afbeelding 2024-12-07 om 19 23 23

Mobile (light)

BeforeAfter
Scherm­afbeelding 2024-12-07 om 19 21 17 Scherm­afbeelding 2024-12-07 om 19 16 59

Mobile (dark)

BeforeAfter
Scherm­afbeelding 2024-12-07 om 19 21 22 Scherm­afbeelding 2024-12-07 om 19 17 12

Copy link

changeset-bot bot commented Dec 7, 2024

🦋 Changeset detected

Latest commit: 928686f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 7, 2024
Copy link

netlify bot commented Dec 7, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 928686f
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/675492ec2c3bd80008dc4a84
😎 Deploy Preview https://deploy-preview-2661--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant