Skip to content

fix: add right sidebar scrollbar (#1746) #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add right sidebar scrollbar (#1746) #1770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec42ec3
fix: add right sidebar scrollbar (#1746)
techfg Apr 19, 2024
e273401
chore: add changeset
techfg Apr 19, 2024
de7ce88
chore: formatting
techfg Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-fans-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/starlight': patch
---

Fixes accessibility by adding scrollbar to right sidebar
1 change: 1 addition & 0 deletions packages/starlight/components/PageSidebar.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ import TableOfContents from 'virtual:starlight/components/TableOfContents';
) * 0.25 /* MAGIC NUMBER 🥲 */
)
);
width: auto;
}
}
</style>
12 changes: 6 additions & 6 deletions packages/starlight/components/TwoColumnContent.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ import type { Props } from '../props';
}

.right-sidebar {
position: fixed;
top: 0;
position: sticky;
top: var(--sl-nav-height);
border-inline-start: 1px solid var(--sl-color-gray-6);
padding-top: var(--sl-nav-height);
width: 100%;
height: 100vh;
max-width: var(--sl-sidebar-width);
width: auto;
height: calc(100vh - var(--sl-nav-height));
overflow-y: auto;
scrollbar-width: none;
margin-right: var(--sl-sidebar-pad-x);
}

.main-pane {
Expand Down