-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: add experimetal svgo docs #12637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this docs PR @azat-io ! It's wonderfully well-written and a pleasure to read!
I made some initial comments/thoughts here, because I still want some questions answered in the other PR first before we look at this one too closely. Just want to make sure we're clear on the feature before we hit the docs too hard, but it's now a work in progress! 🙌
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the further clarifications and updates!
I've left already a handful of comments below for some reworking of the page here for your consideration.
Also, given that this works only for SVG components, in general, let's use the term "SVG component imports" instead of "SVG imports." This avoids the question of whether this does anything for SVG's not used specifically as components. (For example, people might wonder about using this with UI framework components, but the SVG component pattern is only for Astro components.)
I know below is a lot, so I'm going to stop now and let you look over it all! 😄
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
|
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
|
This looks fantastic @azat-io , thank you! Just one broken link here, as mentioned, but then I think this is great! |
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah Rainsberger <[email protected]>
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for all your work and responsiveness getting these docs done, @azat-io ! Assuming nothing about this feature changes, these docs will be ready to merge when 5.16.0 is released! 🥳
|
@yanthomasdev - feel free to review at any time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks useful! LGTM, I only left two nits (wrong highlighted line and a link that seems a bit odd to me).
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/en/reference/experimental-flags/svg-optimization.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Armand Philippot <[email protected]>
Description (required)
Adds documentation for the new experimental SVG optimization feature.
Related to: withastro/astro#13880
/reference/experimental-flags/svg/Related issues & labels (optional)
N/A.