-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
i18n(ja): update guides/imports.mdx
#12449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bd65dbe
i18n(ja): replace Astro.glob with import.meta.glob in guides/imports.mdx
tkskto 30f0af3
i18n(ja): adjust to ja rules.
tkskto fc6ab42
i18n(ja): fix broken fragment link.
tkskto 4d95e05
i18n(ja): fixed incorrect explanation.
tkskto cb4de1f
Apply suggestions from code review
tkskto 5594ac5
Merge branch 'v6' into i18n/ja/guide-imports
yanthomasdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感想です。
日本語のドキュメントしか、確認できてないんですが
import.meta.glob()の戻り値は配列ではなくオブジェクト(連想配列)なのかなと考えていました。配列で扱いたいならObject.values()を使ってから処理することになりそうです。https://vite.dev/guide/features.html#glob-import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
おっしゃる通りでした!ありがとうございます!