Skip to content

add SvgComponent type docs #12406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2025
Merged

add SvgComponent type docs #12406

merged 2 commits into from
Sep 24, 2025

Conversation

sarah11918
Copy link
Member

Description (required)

This PR adds a section to the Images guide for the new SvgComponent type

Related issues & labels (optional)

For Astro version: 5.14.0. See astro PR #13651. -->

@sarah11918 sarah11918 added this to the 5.14.0 milestone Sep 23, 2025
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Sep 23, 2025
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 933d866
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68d2f0ff6c5e37000857f799
😎 Deploy Preview https://deploy-preview-12406--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sarah11918 sarah11918 mentioned this pull request Sep 23, 2025
Merged
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 23, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/images.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

ArmandPhilippot
ArmandPhilippot reviewed Sep 23, 2025
View reviewed changes
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions mostly to fix the syntax highlighting, otherwise, yes I think this might be enough! 🙌🏽

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Sep 24, 2025
@sarah11918 sarah11918 changed the base branch from main to 5.14.0 September 24, 2025 11:35
yanthomasdev
yanthomasdev approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarah11918 sarah11918 merged commit bd3cdf0 into 5.14.0 Sep 24, 2025
10 checks passed
@sarah11918 sarah11918 deleted the sarah11918-patch-1 branch September 24, 2025 13:11
@sarah11918 sarah11918 mentioned this pull request Sep 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot left review comments

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!

Projects

None yet

Milestone

5.14.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sarah11918 @astrobot-houston @ArmandPhilippot @yanthomasdev