-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[v6]: remove Astro.glob() [i18nIgnore] #12401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌑 This pull request will not trigger status changes. Learn moreLunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: You can change this by either removing the keyword above from the PR's title, or modifying the Tracked FilesNote The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.
Warnings reference
|
@florian-lefebvre - In this PR, can you also update the English error messages that reference I think some past upgrade guides (maybe even in multiple languages) might also refer to the It'll be more work to update outdated translation pages (guides, reference, error messages) that might still reference older pages, so don't worry about those just yet. Yan and I will use that to help alert us that some translations pages are too old and might need removing. |
@yanthomasdev And so it begins... we can start to use failed link checks because of outdated translations to help us find translations that are too old and need to be removed! |
I wonder whether @jp-knj could help us with the failing Japanese links here: Kenji, how out of date is the "Imports" page? Do you feel we could easily get this updated, or should we remove the translation as too outdated? Also, this probably means that the Japanese tutorial hasn't been updated for v5 if it's still using |
@florian-lefebvre I think the only conflict here is that GitHub isn't smart enough to realize that it's OK to add two new "Removed" items 😅 This should be simple for you to resolve, I think? |
Thanks! I did a quick pass. Imports page (ja): It’s outdated, still presents Astro.glob() as a normal API. I recommend updating rather than removing. Tutorial (ja): Parts still rely on Astro.glob(), so it’s not fully v5-ready. I also recommend update-not-remove for the Japanese tutorial. I’ll reach out on Discord to see if any Japanese translators are available to help! If no one’s available, I’m good to take this on. |
Okay, I'll make times to do this! |
Do we have to wait until the translations links are fixed? Asking because I have a WIP code PR that depends on the removal of |
No, but we should get a changeset written for your astro PR! (I can handle links separately). Are you OK to whip something up for that from this, @florian-lefebvre ? |
@florian-lefebvre I believe I've addressed all the links here! @jp-knj See this commit for temporary emergency changes I made to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Florian, this one can merge. I've fixed all the broken links in translated pages!
Description (required)
Removes
Astro.glob()
.Related issues & labels (optional)
For Astro version:
6.0
. See astro PR #14421.