Skip to content

Conversation

florian-lefebvre
Copy link
Member

Description (required)

Removes Astro.glob().

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 6.0. See astro PR #14421.

@florian-lefebvre florian-lefebvre added this to the v6.0.0 docs milestone Sep 23, 2025
@netlify
Copy link

netlify bot commented Sep 23, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 3cbb195
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68d45e4917d9a90008d05227
😎 Deploy Preview https://deploy-preview-12401--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 23, 2025

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: i18nIgnore.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

File Note
en/guides/upgrade-to/v6.mdx Source changed, localizations will be marked as outdated.
en/reference/api-reference.mdx Source changed, localizations will be marked as outdated.
en/reference/errors/astro-glob-no-match.mdx Source changed, localizations will be marked as outdated.
en/reference/errors/astro-glob-used-outside.mdx Source changed, localizations will be marked as outdated.
it/guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
ja/guides/imports.mdx Localization changed, will be marked as complete.
ja/guides/integrations-guide/netlify.mdx Localization changed, will be marked as complete.
ja/guides/markdown-content.mdx Localization changed, will be marked as complete.
ja/guides/migrate-to-astro/from-create-react-app.mdx Localization changed, will be marked as complete.
ja/guides/migrate-to-astro/from-gridsome.mdx Localization changed, will be marked as complete.
ja/guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
ja/recipes/rss.mdx Localization changed, will be marked as complete.
ja/tutorial/5-astro-api/1.mdx Localization changed, will be marked as complete.
pl/guides/imports.mdx Localization changed, will be marked as complete.
pl/guides/upgrade-to/v2.mdx Localization changed, will be marked as complete.
pl/recipes/rss.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added the 6.0 label Sep 23, 2025
@sarah11918
Copy link
Member

sarah11918 commented Sep 23, 2025

@florian-lefebvre - In this PR, can you also update the English error messages that reference Astro.glob() (it should be fine to just remove the links)

I think some past upgrade guides (maybe even in multiple languages) might also refer to the Astro.glob() section. So similarly, removing links from them will help the link checker.

It'll be more work to update outdated translation pages (guides, reference, error messages) that might still reference older pages, so don't worry about those just yet. Yan and I will use that to help alert us that some translations pages are too old and might need removing.

@sarah11918
Copy link
Member

@yanthomasdev And so it begins... we can start to use failed link checks because of outdated translations to help us find translations that are too old and need to be removed!

@sarah11918
Copy link
Member

I wonder whether @jp-knj could help us with the failing Japanese links here:
image

Kenji, how out of date is the "Imports" page? Do you feel we could easily get this updated, or should we remove the translation as too outdated?

Also, this probably means that the Japanese tutorial hasn't been updated for v5 if it's still using Astro.glob()? Do you think we could get some translators to focus on updating this?

@sarah11918
Copy link
Member

@florian-lefebvre I think the only conflict here is that GitHub isn't smart enough to realize that it's OK to add two new "Removed" items 😅 This should be simple for you to resolve, I think?

@jp-knj
Copy link
Member

jp-knj commented Sep 24, 2025

@sarah11918

Thanks! I did a quick pass.

Imports page (ja): It’s outdated, still presents Astro.glob() as a normal API. I recommend updating rather than removing.

Tutorial (ja): Parts still rely on Astro.glob(), so it’s not fully v5-ready. I also recommend update-not-remove for the Japanese tutorial.

I’ll reach out on Discord to see if any Japanese translators are available to help!

If no one’s available, I’m good to take this on.

@sarah11918
Copy link
Member

Thank you @jp-knj ! I will also note that we'll probably be merging some tutorial updates soon in #12171 too, so something to keep an eye on!

@jp-knj
Copy link
Member

jp-knj commented Sep 24, 2025

Okay, I'll make times to do this!

@florian-lefebvre
Copy link
Member Author

Do we have to wait until the translations links are fixed? Asking because I have a WIP code PR that depends on the removal of Astro.glob (no rush tho)

@sarah11918
Copy link
Member

No, but we should get a changeset written for your astro PR! (I can handle links separately). Are you OK to whip something up for that from this, @florian-lefebvre ?

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 24, 2025
@sarah11918 sarah11918 changed the title [v6]: remove Astro.glob() [v6]: remove Astro.glob() [i18nIgnore] Sep 24, 2025
@sarah11918
Copy link
Member

sarah11918 commented Sep 24, 2025

@florian-lefebvre I believe I've addressed all the links here!

@jp-knj See this commit for temporary emergency changes I made to /ja/ docs:

  • the Markdown page was extremely out of date, and had been rewritten in the mean time so I deleted this one (past versions can be used to recreate a new page when someone has the time!) Interestingly, this page did not show up in our tracker as outdated, so I guess no one realized it needed updating! OK, deleting this was a big mistake for other links! 😅 I just removed the offending link, but this page is really out of date and we'll either need to update or delete, I think!
  • the Imports page: I just removed the entire section on Astro.glob() (so now it's missing a section for import.meta.glob(). So, at least the rest of the page is only slightly out of date, and the new section can be added back. I also had to remove some links in various other pages that linked to Astro.glob (or import.meta.glob) here. But the other pages are fine without links in the meantime, the content is unchanged.
  • the v2 guide just needed the link removed, but we wouldn't update text for an older version upgrade guide
  • the tutorial page was just a link as a reference. (BUT that means the tutorial text probably relies on Astro.glob() as we discussed, so it will need revision to be accurate for v6.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Florian, this one can merge. I've fixed all the broken links in translated pages!

@florian-lefebvre florian-lefebvre merged commit f7e6625 into v6 Sep 25, 2025
11 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/remove-astro-glob branch September 25, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.0 i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants