Skip to content

feat: getFontData() #12345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 24, 2025
Merged

feat: getFontData() #12345

merged 6 commits into from
Sep 24, 2025

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Sep 19, 2025 •
edited
Loading

Description (required)

Documents a new getFontData() fonction in experimental Fonts.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@florian-lefebvre florian-lefebvre self-assigned this Sep 19, 2025
@netlify
Copy link

netlify bot commented Sep 19, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit a65f2e0
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68d3d75eea79ba0008256908
😎 Deploy Preview https://deploy-preview-12345--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@florian-lefebvre florian-lefebvre mentioned this pull request Sep 19, 2025
Merged
3 tasks
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 19, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@florian-lefebvre florian-lefebvre marked this pull request as ready for review September 19, 2025 07:37
florian-lefebvre
florian-lefebvre commented Sep 19, 2025
View reviewed changes
sarah11918
sarah11918 reviewed Sep 19, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the pieces we need are here! Let's keep workshopping this!

florian-lefebvre
florian-lefebvre commented Sep 22, 2025
View reviewed changes
@florian-lefebvre @sarah11918
Apply suggestions from code review
a776f4c 
Co-authored-by: Sarah Rainsberger <[email protected]>
sarah11918
sarah11918 approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! Happy with it when you are, Florian!

@sarah11918
Copy link
Member

Is this for 5.14? Is there an implementation PR? Can you add that extra context when known? Thanks!

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Sep 22, 2025
@florian-lefebvre
Copy link
Member Author

Sorry, yes it's a 5.14 PR! Implementation at withastro/astro#13811

@florian-lefebvre florian-lefebvre added this to the 5.14.0 milestone Sep 23, 2025
@sarah11918 sarah11918 added minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Sep 23, 2025
@sarah11918 sarah11918 changed the base branch from main to 5.14.0 September 24, 2025 11:36
yanthomasdev
yanthomasdev reviewed Sep 24, 2025
View reviewed changes
@sarah11918 sarah11918 mentioned this pull request Sep 24, 2025
Merged
@sarah11918 sarah11918 merged commit 853ccd7 into 5.14.0 Sep 24, 2025
6 checks passed
@sarah11918 sarah11918 deleted the feat/get-font-data branch September 24, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

@florian-lefebvre florian-lefebvre

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!

Projects

None yet

Milestone

5.14.0

Development

Successfully merging this pull request may close these issues.

5 participants

@florian-lefebvre @astrobot-houston @sarah11918 @yanthomasdev