Fix head content parsing issue #1098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes an issue with head content parsing when such content is defined in a component that first renders another component before other elements like
<title>
when using an expression for the title.When first encoutering a start tag token for a component before any HTML, we switch to the "in body" insertion mode. After that, when we encounter a start tag token for some head related tags, we use the "in head" insertion mode to parse them correctly. Altho, when we later encounter the associated end tag token, we do not switch back to the "in head" insertion mode, which causes invalid markup to be generated.
For example, considering the following Astro component supposed to be rendered in the head:
The generated code before this fix was invalid (notice the
meta
tag is inside thetitle
tag):Testing
I added a new print test case for a similar scenario as the one described in the issue which generates a snapshot file with the expected output after the fix.
Docs
This is a bug fix only, so no docs were added or updated.