Skip to content

improve menu accessibility #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 25, 2025
Merged

improve menu accessibility #44

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d1e1111
update hamburger component to use button element
bjohansebas Aug 18, 2025
cf50bfa
improve accesibilidad of menu
bjohansebas Aug 19, 2025
ee485c2
apply suggestions
bjohansebas Aug 20, 2025
6346f4c
apply suggestions
bjohansebas Aug 21, 2025
fef9570
rename hambuguer variable and remove some unused lines
bjohansebas Aug 21, 2025
ad95b97
fix link colors in dark mode
bjohansebas Aug 21, 2025
d275597
improve links in dark mode
bjohansebas Aug 21, 2025
0ed17f0
add aria attributes to theme toggle button for accessibility
bjohansebas Aug 23, 2025
2d152a5
fix accessibility by moving aria-hidden attribute to the SVG element
bjohansebas Aug 24, 2025
b4e78ea
change skills colour on about page
sarah11918 Aug 28, 2025
b6d2ffe
skillcolor on about page lower case
sarah11918 Aug 28, 2025
012f85c
remove blank lines
sarah11918 Aug 28, 2025
476dd2a
apply suggestions
bjohansebas Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,6 @@ html.dark {
color: #0d0950;
}

.dark .nav-links a {
.dark a {
color: #fff;
}
Copy link
Member

@sarah11918 sarah11918 Aug 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't let me suggest, but we want something more like this:

.dark .nav-links a {
  color: #fff;
}

.dark a {
  color: #ff9776;
}

We want to keep the nav links white (the pages) but only update regular links, because we still want links to be distinguished inside text:

image

It probably makes the most sense to have links be a different color than the text, so our friend orange seems like a good candidate here!

Copy link
Contributor Author

@bjohansebas bjohansebas Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extreme cases, but it’s resolved with the text you mentioned on Discord.
imagen

Copy link
Member

@sarah11918 sarah11918 Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, noticed that but it's not terrible... I think the text covers this fine.

Copy link
Member

@ArmandPhilippot ArmandPhilippot Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems fine. This is not the most readable, but according to Firefox accessibility tools this is still AA (5.19), so I think this is more than enough for the tutorial.