Skip to content

improve menu accessibility #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 25, 2025
Merged

improve menu accessibility #44

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d1e1111
update hamburger component to use button element
bjohansebas Aug 18, 2025
cf50bfa
improve accesibilidad of menu
bjohansebas Aug 19, 2025
ee485c2
apply suggestions
bjohansebas Aug 20, 2025
6346f4c
apply suggestions
bjohansebas Aug 21, 2025
fef9570
rename hambuguer variable and remove some unused lines
bjohansebas Aug 21, 2025
ad95b97
fix link colors in dark mode
bjohansebas Aug 21, 2025
d275597
improve links in dark mode
bjohansebas Aug 21, 2025
0ed17f0
add aria attributes to theme toggle button for accessibility
bjohansebas Aug 23, 2025
2d152a5
fix accessibility by moving aria-hidden attribute to the SVG element
bjohansebas Aug 24, 2025
b4e78ea
change skills colour on about page
sarah11918 Aug 28, 2025
b6d2ffe
skillcolor on about page lower case
sarah11918 Aug 28, 2025
012f85c
remove blank lines
sarah11918 Aug 28, 2025
476dd2a
apply suggestions
bjohansebas Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/components/Hamburger.astro
View file
Open in desktop

This file was deleted.

16 changes: 12 additions & 4 deletions src/components/Header.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,21 @@
---
import Hamburger from "./Hamburger.astro";
import Menu from "./Menu.astro";
import Navigation from "./Navigation.astro";
import ThemeIcon from "./ThemeIcon.astro";
---

<header>
<nav>
<Hamburger />
<ThemeIcon />
<nav aria-label="Main menu">
<div>
<Menu />
<ThemeIcon />
</div>
<Navigation />
</nav>
</header>

<style>
div {
display: flex;
}
</style>
6 changes: 6 additions & 0 deletions src/components/Menu.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
---

<button aria-expanded="false" aria-controls="main-menu" class="menu">
Menu
</button>
2 changes: 1 addition & 1 deletion src/components/Navigation.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
---
<div class="nav-links">
<div id="main-menu" class="nav-links">
<a href="/">Home</a>
<a href="/about/">About</a>
<a href="/blog/">Blog</a>
Expand Down
2 changes: 1 addition & 1 deletion src/components/ThemeIcon.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
---

<button id="themeToggle">
<button id="themeToggle" aria-hidden="true" aria-label="Toggle theme">
<svg width="30px" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
<path
class="sun"
Expand Down
7 changes: 5 additions & 2 deletions src/scripts/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
document.querySelector('.hamburger').addEventListener('click', () => {
document.querySelector('.nav-links').classList.toggle('expanded');
const menu = document.querySelector('.menu')

menu.addEventListener('click', () => {
const isExpanded = menu.getAttribute('aria-expanded') === 'true';
menu.setAttribute('aria-expanded', !isExpanded);
});
39 changes: 24 additions & 15 deletions src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,24 +22,18 @@ h1 {

/* nav styles */

.hamburger {
padding-right: 20px;
cursor: pointer;
.menu {
background-color: #0d0950;
border: none;
color: #fff;
font-size: 1.2rem;
font-weight: bold;
padding: 5px 10px;
}

.hamburger .line {
display: block;
width: 40px;
height: 5px;
margin-bottom: 10px;
background-color: #ff9776;
}

.nav-links {
width: 100%;
top: 5rem;
left: 48px;
background-color: #ff9776;
display: none;
margin: 0;
}
Expand All @@ -52,14 +46,15 @@ h1 {
font-size: 1.2rem;
font-weight: bold;
text-transform: uppercase;
color: #0d0950;
}

.nav-links a:hover,
.nav-links a:focus {
background-color: #ff9776;
}

.expanded {
:has(.menu[aria-expanded="true"]) .nav-links {
display: unset;
}

Expand All @@ -77,7 +72,7 @@ h1 {
padding: 15px 20px;
}

.hamburger {
.menu {
display: none;
}
}
Expand All @@ -87,6 +82,20 @@ html.dark {
color: #fff;
}

.dark .menu {
background-color: #fff;
color: #000;
}

.dark .nav-links a:hover,
.dark .nav-links a:focus {
color: #0d0950;
}

.dark .nav-links a {
color: #fff;
}

.dark a {
color: #ff9776;
}