-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
refactor(actions): plugin and virtual modules #14538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: da1d710 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #14538 will not alter performanceComparing Summary
Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, that's a great refactor. Thank you @florian-lefebvre! I left some comments, but they are mostly open-ended
Changes
virtual-modules/i18n.ts
. Allowed to spot some runtime things that were incorrectactions/runtime/virtual
were not only imported by the virtual module, so I moved them toactions/runtime
Testing
Should pass
Docs
Technically doesn't need a changeset but I'll include one to be safe