fix(astro): invalid resolution of non-ascii target paths by rewrite #14467
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6cff47c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
gwennlbh
force-pushed
the
fix-non-ascii-rewrites
branch
from
676517e to
c3af294
Compare
CodSpeed Performance ReportMerging #14467 will not alter performanceComparing Summary
Footnotes |
|
Hi! Do you need any help? I believe adding a test should be enough to make this PR ready |
|
hello! sorry, I got a bit busy haha what kind of tests would be appropriate here? i guess E2E, unit too? do I have to make a new test or do I add a case in an existing one ? |
|
No problem! I'm not 100% sure, probably a unit test and an integration test if you don't mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Makes
findRouteToRewritecompare routes' href against the encoded result (target) path, instead of the decoded one, since hrefs are encodedCloses #14464
Testing
Not done yet. Waiting on feedback on the issue to see if this diff is okay before writing a test
Docs
Doesn't affect docs since it's just a bug fix for what was a unexpected behavior of
Astro.rewrite