Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Sep 26, 2025

Changes

  • Closes Remove routes on astro:build:done #14444
  • Removes routes from astro:build:done
  • Removes entryPoints from astro:build:ssr as it was unused since the removal of functionPerRoute
  • Removes the IntegrationRouteData type

Testing

Updated

Docs

withastro/docs#12445

@florian-lefebvre florian-lefebvre added this to the v6.0.0 milestone Sep 26, 2025
@florian-lefebvre florian-lefebvre self-assigned this Sep 26, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2025

🦋 Changeset detected

Latest commit: e894dd5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) docs pr semver: major Change triggers a `major` release labels Sep 26, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@florian-lefebvre florian-lefebvre marked this pull request as ready for review September 29, 2025 09:10
@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Sep 29, 2025
```diff
// my-integration.mjs
const integration = () => {
+ let routes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is unaligned with the rest

Suggested change
+ let routes
+ let routes

@sarah11918
Copy link
Member

@florian-lefebvre I'm just curious about the changesets being for the specific integrations only. This removes some stuff (including the IntegrationRouteDataType) from the Integrations API entirely, right? Does this mean that some integration authors might need to know about this in the context of their own integrations? Are these things that are literally only used, one for sitemap and one for the Vercel integration? (Just checking because that seems really specific. But then again, maybe that's why it's safe to get rid of them!)

@florian-lefebvre
Copy link
Member Author

All integration authors are affected. I chose to scope the changesets to astro + each official integration it affects because it made sense to me, but now that you're saying it maybe it's not that relevant! Technically, changes made to these integrations are not public facing

@sarah11918
Copy link
Member

sarah11918 commented Sep 29, 2025

OK, yeah in that case this feels like a change to the Integrations API proper, and should be represented as an Astro change? (That just happens to affect some of our own existing official integrations)

I'd only have ONE changeset, listing ALL the things removed from the Integrations API. And then have the multiple examples in the "what should I do?"

@florian-lefebvre
Copy link
Member Author

Updated!

@sarah11918
Copy link
Member

lol, two changesets is fine! 😄 let me read them now!

@florian-lefebvre
Copy link
Member Author

Yeah sorry, I kinda prefer 2 changesets for it

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some tiny tiny bits of polishing suggestions, in part to make this extra super obvious that this affects Astro integrations only! But this is great!

Co-authored-by: Sarah Rainsberger <[email protected]>
@florian-lefebvre florian-lefebvre merged commit ece667a into next Sep 29, 2025
4 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/integration-api-cleanup branch September 29, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 action Modifies GitHub Actions docs pr pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) semver: major Change triggers a `major` release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants