-
-
Couldn't load subscription status.
- Fork 2.9k
feat: cleanup integration api #14446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e894dd5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.
.changeset/cuddly-worlds-beam.md
Outdated
| ```diff | ||
| // my-integration.mjs | ||
| const integration = () => { | ||
| + let routes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is unaligned with the rest
| + let routes | |
| + let routes |
|
@florian-lefebvre I'm just curious about the changesets being for the specific integrations only. This removes some stuff (including the |
|
All integration authors are affected. I chose to scope the changesets to |
|
OK, yeah in that case this feels like a change to the Integrations API proper, and should be represented as an Astro change? (That just happens to affect some of our own existing official integrations) I'd only have ONE changeset, listing ALL the things removed from the Integrations API. And then have the multiple examples in the "what should I do?" |
|
Updated! |
|
lol, two changesets is fine! 😄 let me read them now! |
|
Yeah sorry, I kinda prefer 2 changesets for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some tiny tiny bits of polishing suggestions, in part to make this extra super obvious that this affects Astro integrations only! But this is great!
Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
routesonastro:build:done#14444routesfromastro:build:doneentryPointsfromastro:build:ssras it was unused since the removal offunctionPerRouteIntegrationRouteDatatypeTesting
Updated
Docs
withastro/docs#12445