Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Sep 23, 2025

Changes

  • Closes Drop Node v18 #14365
  • Removes polyfills for node 18 and node 20 (import.meta.resolve)
  • Update CLI entrypoints
  • Keep undocumented support for node 20. Once stackblitz supports 22, we'll have to quietly hard require node 22

Testing

Should still pass

Docs

withastro/docs#12423 + changeset

@florian-lefebvre florian-lefebvre added this to the v6.0.0 milestone Sep 23, 2025
@florian-lefebvre florian-lefebvre self-assigned this Sep 23, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2025

🦋 Changeset detected

Latest commit: 65fadd7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Sep 23, 2025
@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Sep 23, 2025
@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: create-astro Related to the `create-astro` package (scope) labels Sep 23, 2025
@github-actions github-actions bot added the semver: major Change triggers a `major` release label Sep 23, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@github-actions github-actions bot added the feat: markdown Related to Markdown (scope) label Sep 23, 2025
@gacek1123
Copy link

I am far from knowledgeable on this, but shouldn't Astro go straight for Node 22 while there's already a major version bump, to avoid having to hold back some dependency upgrades once again after Node 20 goes EOL?

@florian-lefebvre
Copy link
Member Author

We discussed that but Stackblitz does not support v22 just yet. We hope it will until the stable release of Astro 6 but in the meantime, we have to stay on v20

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Sep 25, 2025
@github-actions github-actions bot removed the pkg: example Related to an example package (scope) label Sep 25, 2025
],
"engines": {
"node": "^18.20.8 || ^20.3.0 || >=22.0.0"
"node": ">=22.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires node 22 in the monorepo

@florian-lefebvre florian-lefebvre marked this pull request as ready for review September 25, 2025 13:39
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@florian-lefebvre florian-lefebvre changed the title feat!: drop node 18 feat!: drop node 18 and 20 Sep 25, 2025
@florian-lefebvre florian-lefebvre merged commit e131261 into next Sep 25, 2025
18 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/drop-node-18 branch September 25, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 action Modifies GitHub Actions feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) semver: major Change triggers a `major` release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants