- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.9k
 
feat!: drop node 18 and 20 #14427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: drop node 18 and 20 #14427
Conversation
          🦋 Changeset detectedLatest commit: 65fadd7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.
This reverts commit 74a056a.
| 
           I am far from knowledgeable on this, but shouldn't Astro go straight for Node 22 while there's already a major version bump, to avoid having to hold back some dependency upgrades once again after Node 20 goes EOL?  | 
    
| 
           We discussed that but Stackblitz does not support v22 just yet. We hope it will until the stable release of Astro 6 but in the meantime, we have to stay on v20  | 
    
| ], | ||
| "engines": { | ||
| "node": "^18.20.8 || ^20.3.0 || >=22.0.0" | ||
| "node": ">=22.0.0" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires node 22 in the monorepo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done
Changes
import.meta.resolve)Testing
Should still pass
Docs
withastro/docs#12423 + changeset