fix(routing): improve error handling

[ematipico]

Changes

Closes #12036

Astro didn't perform any validation of the route mappings. This PR introduces a new function that performs this task.

An error is thrown when a redirect can't be mapped to a new route.

Testing

Added a new test

Docs

[changeset-bot]

🦋 Changeset detected

Latest commit: 9bdc5ad

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #14161 will not alter performance

_{Comparing fix/routing-validation (92632a6) with main (34e6b3a)¹}

Summary

✅ 6 untouched benchmarks

Footnotes

1. No successful run was found on main (c86b5bb) during the generation of this report, so 34e6b3a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[ascorbic]

What would be the behaviour now, if one of these invalid redirects was created?

[ematipico]

What would be the behaviour now, if one of these invalid redirects was created?

As mentioned in the bug report, the error is generic:

[ERROR] [build] Failed to call getStaticPaths for /categories/[category]
[GetStaticPathsRequired] `getStaticPaths()` function is required for dynamic routes. Make sure that you `export` a `getStaticPaths` function from your dynamic route.

[ascorbic]

This still doesn't test for the example in the issue, and I'm not sure it would catch it. The original had the same number of dynamic segments on each side:

redirects: {
  '/categories/[category]': '/category/[category]/1',
}

[ematipico]

Sorry, I missed that. I'll add a test for that too

[florian-lefebvre]

@ematipico what are your plans for this PR?