Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUP-4139:axios upgrade to 0.28.0 #975

Merged
merged 6 commits into from
May 8, 2024
Merged

WINDUP-4139:axios upgrade to 0.28.0 #975

merged 6 commits into from
May 8, 2024

Conversation

m-brophy
Copy link
Contributor

@m-brophy m-brophy commented Apr 4, 2024

@m-brophy m-brophy added Ready to Review auto-backport Set the PR for being backported labels Apr 4, 2024
@m-brophy m-brophy requested a review from PhilipCattanach April 4, 2024 17:01
@PhilipCattanach PhilipCattanach added the auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch label Apr 7, 2024
@PhilipCattanach
Copy link
Contributor

@carlosthe19916 - Can you review this PR please?

carlosthe19916
carlosthe19916 requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@carlosthe19916 carlosthe19916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment at windup/windup#1728 (review) applies here as well.

Direct dependencies can be updates as:

yarn install
yarn add [email protected] --exact

After that is done, we have to acknowledge that there is breaking changes due to the Axios upgrade. I created this PR to your branch to fix the errors in the builds m-brophy#3

Do you mind reviewing it, it woudn't also hurt build Windup web and then quickly run it to see if everything still works, no deep testing , just to make sure the UI works.

@carlosthe19916
Copy link
Member

@m-brophy Under the same logic as windup/windup#1728 (comment) I created this PR to your branch m-brophy#4

@m-brophy m-brophy changed the title WINDUP-4139:axios upgrade to 1.6.0 WINDUP-4139:axios upgrade to 0.28.0 Apr 16, 2024
@m-brophy m-brophy merged commit 1bae7a7 into windup:master May 8, 2024
5 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

💔 All backports failed

Status Branch Result
❌ releases/6.3.z Backport failed because of merge conflicts

You might need to backport the following PRs to releases/6.3.z:
- upgrade follow-redirects to 1.15.6 (#976)

Manual backport

To create the backport manually run:

backport --pr 975

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

m-brophy added a commit to m-brophy/windup-web that referenced this pull request May 8, 2024
@m-brophy
WINDUP-4139:axios upgrade to 0.28.0 (windup#975)
d6b3c92 
* axios upgrade to 1.6.0

* merge Carlos PR

* install axios 1.6.0 properly

* Use axios 0.28

---------

Co-authored-by: carlosthe19916 <[email protected]>
(cherry picked from commit 1bae7a7)
@m-brophy m-brophy mentioned this pull request May 8, 2024
Merged
@m-brophy
Copy link
Contributor Author

m-brophy commented May 8, 2024

💚 All backports created successfully

Status Branch Result
✅ releases/6.3.z

Questions ?

Please refer to the Backport tool documentation

m-brophy added a commit that referenced this pull request May 8, 2024
@m-brophy
WINDUP-4139:axios upgrade to 0.28.0 (#975) (#982)
39aee0f 
* axios upgrade to 1.6.0

* merge Carlos PR

* install axios 1.6.0 properly

* Use axios 0.28

---------

Co-authored-by: carlosthe19916 <[email protected]>
(cherry picked from commit 1bae7a7)
@m-brophy m-brophy deleted the WINDUP-4139 branch May 8, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosthe19916 carlosthe19916 carlosthe19916 approved these changes

@PhilipCattanach PhilipCattanach Awaiting requested review from PhilipCattanach

Assignees
No one assigned
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch Ready to Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-brophy @PhilipCattanach @carlosthe19916