Repository navigation
feat: add Lightning - #2059
feat: add Lightning#2059
Conversation
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Adds Lightning, a new third-party Matrix client, to the deb-get installable catalog. This expands exposure to a new upstream and relies on a support-matrix decision, so a human should approve.
Re-trigger cubic
|
A note on the failing |
|
It would be good if packages not supported on the CI runner release resulted in SKIP not FAIL. |
Closes #2053
Adds Lightning, the Qt Quick Matrix client, as
lightning(thePackagename in the upstream.deb).Upstream publishes two amd64
.debs per release, and its README lists them as "for Debian 13+ or Ubuntu 26.04+":lightning_<version>_amd64.deb, built for Debian 13 (Qt 6.8, GStreamer 1.26.2)lightning_<version>_ubuntu2604_amd64.deb, built for Ubuntu 26.04 (Qt 6.10, GStreamer 1.28)So the definition sets
CODENAMES_SUPPORTED="trixie forky sid resolute"and picks theubuntu2604_file onresolute, the same wayappimagelauncherpicks itsbionic_file on bullseye.VERSION_PUBLISHEDcomes from the tag (v0.10.1→0.10.1), which matches theVersionfield in both files.How I tested it:
deb-get show lightningin Debian 13 and Ubuntu 26.04 containers, with this branch's manifest and packages in/etc/deb-getand the release JSON pre-filled in the cache (nothing fetched):Published: 0.10.1,Download: …/v0.10.1/lightning_0.10.1_amd64.debPublished: 0.10.1,Download: …/v0.10.1/lightning_0.10.1_ubuntu2604_amd64.debapt-get install -sof each file, to check that the codename list matches what installs:_amd64.deb_ubuntu2604_amd64.debThe Debian file also resolves on Ubuntu 25.10, but upstream doesn't list it, so I left
questingout.No package named
lightningexists in the Debian 13 or Ubuntu 26.04 archives.README.md is left for you to regenerate, as CONTRIBUTING asks.