Skip to content

feat: add Lightning - #2059

Merged
philclifford merged 1 commit into
wimpysworld:mainfrom
bercedev:add-lightning
Oct 23, 2026
Merged

philclifford merged 1 commit into
wimpysworld:mainfrom
bercedev:add-lightning

Conversation

@bercedev

Copy link
Copy Markdown
Contributor

Closes #2053

Adds Lightning, the Qt Quick Matrix client, as lightning (the Package name in the upstream .deb).

Upstream publishes two amd64 .debs per release, and its README lists them as "for Debian 13+ or Ubuntu 26.04+":

  • lightning_<version>_amd64.deb, built for Debian 13 (Qt 6.8, GStreamer 1.26.2)
  • lightning_<version>_ubuntu2604_amd64.deb, built for Ubuntu 26.04 (Qt 6.10, GStreamer 1.28)

So the definition sets CODENAMES_SUPPORTED="trixie forky sid resolute" and picks the ubuntu2604_ file on resolute, the same way appimagelauncher picks its bionic_ file on bullseye. VERSION_PUBLISHED comes from the tag (v0.10.1 → 0.10.1), which matches the Version field in both files.

How I tested it:

  • deb-get show lightning in Debian 13 and Ubuntu 26.04 containers, with this branch's manifest and packages in /etc/deb-get and the release JSON pre-filled in the cache (nothing fetched):

    • Debian 13: Published: 0.10.1, Download: …/v0.10.1/lightning_0.10.1_amd64.deb
    • Ubuntu 26.04: Published: 0.10.1, Download: …/v0.10.1/lightning_0.10.1_ubuntu2604_amd64.deb
  • apt-get install -s of each file, to check that the codename list matches what installs:

    _amd64.deb _ubuntu2604_amd64.deb
    Debian 13 resolves broken deps
    Ubuntu 25.04 broken deps broken deps
    Ubuntu 26.04 resolves resolves

    The Debian file also resolves on Ubuntu 25.10, but upstream doesn't list it, so I left questing out.

  • No package named lightning exists in the Debian 13 or Ubuntu 26.04 archives.

README.md is left for you to regenerate, as CONTRIBUTING asks.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adds Lightning, a new third-party Matrix client, to the deb-get installable catalog. This expands exposure to a new upstream and relies on a support-matrix decision, so a human should approve.

Re-trigger cubic

@bercedev

Copy link
Copy Markdown
Contributor Author

A note on the failing test-package (lightning) check: the job runs on ubuntu-latest (24.04, noble), and lightning isn't in deb-get list there, so it stops at "Package not in supported list". That's expected. Upstream only builds for Debian 13 and Ubuntu 26.04, and on 24.04 apt-get install -s can't satisfy either .deb (Qt ≥ 6.8, libqt6core6t64, GStreamer ≥ 1.26.2). deskflow has the same situation with CODENAMES_SUPPORTED="trixie forky sid questing resolute". The show output in the description comes from Debian 13 and Ubuntu 26.04 containers. If you'd rather keep CI green for packages like this, I'm happy to look at making the job skip packages whose codename list doesn't include the runner's.

@philclifford

Copy link
Copy Markdown
Member

It would be good if packages not supported on the CI runner release resulted in SKIP not FAIL.

@philclifford
philclifford merged commit 06bbe94 into wimpysworld:main Oct 23, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Request: Lightning

2 participants