-
-
Notifications
You must be signed in to change notification settings - Fork 143
feat: add rcloneview #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rasa
wants to merge
5
commits into
wimpysworld:main
Choose a base branch
from
rasa:rs/add-rcloneview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add rcloneview #1437
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01-main/packages/rcloneview
Outdated
get_website "https://rcloneview.com/src/download.html" | ||
if [ "${ACTION}" != "prettylist" ]; then | ||
URL="$(sed -E -n "s/.*href=.(.*linux.*${ARCH}.*\.deb).*/\1/p" "${CACHE_FILE}")" | ||
VERSION_PUBLISHED="$(sed -E -n "N;s/.*Deb.*Linux.*\s+ver\s+([^\s]+).*/\1/pi" "${CACHE_FILE}")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the next line get some whitespace and <\p>
in the version
Suggested change
VERSION_PUBLISHED="$(sed -E -n "N;s/.*Deb.*Linux.*\s+ver\s+([^\s]+).*/\1/pi" "${CACHE_FILE}")" | |
VERSION_PUBLISHED="$(sed -E -n "s/.*Deb.*Linux.*\s+ver\s+([^\s]+).*/\1/pi" "${CACHE_FILE}")" |
We can get a cleaner more complete match from the URL given the current naming scheme.
We have other trial-ware, and the 14 days trial is for pro features - there is a useful free tier. Not a concern. Of more concern is $ rclone_view
[xcb] Unknown sequence number while processing queue
[xcb] Most likely this is a multi-threaded client and XInitThreads has not been called
[xcb] Aborting, sorry about that.
rclone_view: ../../src/xcb_io.c:278: poll_for_event: Assertion `!xcb_xlib_threads_sequence_lost' failed.
and
|
due to oops in unhelpful conflict resolution
Co-authored-by: Phil Clifford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installed fine locally.
edit It's 14-day trialware. Do we allow trialware? It's USD $19.80/yr or $99.80/lifetime.