Patch to fix hanging on unhandled exceptions #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of result set to prevent hanging then raise with original message.
|
Great! |
|
@bigtunacan Sweet! |
|
@bigtunacan great! Could you add a spec for this? |
|
@bcardiff no problem |
|
@bcardiff Done. |
bcardiff
reviewed
Jun 24, 2017
spec/pg/driver_spec.cr
Outdated
|
|
||
| result = PG_DB.query "insert into contacts values ($1)", "Foo" | ||
| result = PG_DB.query "insert into contacts values ($1)", "Foo" do |rs| | ||
| pp rs |
There was a problem hiding this comment.
pp rs puts debug leftover ;-)
There was a problem hiding this comment.
doh!
@bcardiff updated.
bcardiff
approved these changes
Jun 24, 2017
|
Thanks for working on this! |
|
@will Glad to help. Thanks for the shard. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PG would hang indefinitely if an exception was raised, but not handled. This is due to
@endnot being set to true when this occurs so while attempting to process the result_set it gets caught in an infinite loop.Issues related can be seen at
#98
crystal-lang/crystal-db#46
Crecto/crecto#76