Feature: Lights and Shadows #308
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sliders and color picker widgets added
- opacity and brightness granularity and range was changed; - update_axes_range() function updated in order to fix the error caused by y_size changes; - color picker was fixed;
…hadowmap issue. Work in progress lighting demo notebook
…ity. Update mesh transparency and shadows
…r has DEFAULT and PHYSICAL lighting models
added 24 commits
August 7, 2020 13:42
…ng as default for scatter plots
|
#341 |
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
e861e87 to
6dead3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we have added light and shadow support to ipyvolume.
We tried to not interfere with the existing functionality of ipyvolume,
As long as no lights are added, nothing changes for the user.
As soon as a light is added to the Figure (Scene), we change to our custom shaders. But this can also be reversed on the fly by just setting the lighting_mode.
The status is as follows:
plot_mesh, plot_trisurf, plot_surface
These 3 fully support light and shadows for:
spot_light, point_light, directional_light, hemisphere_light and ambient_light
scatter
We only have a working implementation for hemisphere and ambient_light.
Due to a bug in the old threejs version, this does not work correctly.
Please have a look at the issue for more information.
#276
We have added a Notebook with examples for the usage of the new functionality.
Unittests are added.
Inline doc should be present.