Skip to content

Conversation

@icduck
Copy link

@icduck icduck commented Oct 31, 2023

conflict data type between Grid() and builder_params.py. Changed it to string

@icduck icduck closed this Oct 31, 2023
@icduck icduck reopened this Oct 31, 2023
@mariobuikhuizen
Copy link
Contributor

Thanks for this contribution!

I think height_in should be an int looking at this:

height=0,

self.height_in = height

if self.obj.height_in == 0:

self.obj.height = str(self.obj.height_in) + 'px'

At that point it is converted to string and put in the height traitlet which is of type string.

It's a bit of a confusing construction: height: int in the Grid contructor is assigned to self.height_in, which is then converted to string and set in the height: Unicode traitlet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants