Skip to content

Commit

Permalink
Move PyQt_ dependency to a pip-only file (requirements-pip.txt)
Browse files Browse the repository at this point in the history
  • Loading branch information
@baileythegreen
baileythegreen committed Jan 10, 2022
1 parent 54c33ea commit 80082c4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions requirements-pip.txt
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
pre-commit
pytest-ordering
sphinx-rtd-theme
PyQt5
1 change: 0 additions & 1 deletion requirements.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ numpy
openpyxl
pandas
Pillow
PyQt
scipy
seaborn
sqlalchemy==1.3.10
Expand Down

2 comments on commit 80082c4

@widdowquinn
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having pyqt in requirements.txt works for me with make setup_env and, at time of checking, installs v5.12.3.

I think that, unless a package is unavailable in conda's channels, we should always aim to use conda as the package manager, to avoid conflicts as much as we can. Moving installation to requirements-pip.txt should be the less desirable option.

@baileythegreen
Copy link
Contributor Author

@baileythegreen baileythegreen commented on 80082c4 Jan 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also worked for me locally; it did not work in CircleCI, though: 0949a46. I don't know if there's a different way to have it successfully run both locally and in CircleCI, but I have not yet found one.

Please sign in to comment.