Skip to content

Commit

Permalink
Wine 10.0 release patchset
Browse files Browse the repository at this point in the history 
- Rebase
- More cleanup
- Add a small but experimental audio latency reduction tweak
- Add some more useful pending MRs
  • Loading branch information
@whrvt
whrvt committed Jan 21, 2025
1 parent e7fa615 commit d4a6672
Show file tree
Hide file tree
Showing 41 changed files with 2,309 additions and 1,278 deletions.
67 changes: 0 additions & 67 deletions ...syncing-window-position/0001-winex11-Respect-swp-flags-when-syncing-window-position.patch
View file

This file was deleted.

160 changes: 160 additions & 0 deletions ...fixes-for-verify-ssl-policy-/0001-crypt32-Add-more-tests-for-VerifyCertChainPolicy-.patch
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
From 2ab6307bb53361ed7c1a593198dbedb19135f9f6 Mon Sep 17 00:00:00 2001
From: Paul Gofman <[email protected]>
Date: Wed, 8 Jan 2025 19:25:41 -0600
Subject: [PATCH] crypt32: Add more tests for VerifyCertChainPolicy().

---
dlls/crypt32/tests/chain.c | 133 +++++++++++++++++++++++++++++++++++++
1 file changed, 133 insertions(+)

diff --git a/dlls/crypt32/tests/chain.c b/dlls/crypt32/tests/chain.c
index 9717b184c14..d198b92a31c 100644
--- a/dlls/crypt32/tests/chain.c
+++ b/dlls/crypt32/tests/chain.c
@@ -5376,10 +5376,143 @@ static void testVerifyCertChainPolicy(void)
check_msroot_policy();
}

+static void test_VerifyCertChainPolicy_flags(void)
+{
+ static const struct
+ {
+ DWORD trust_status;
+ unsigned int index;
+ DWORD policy_flags;
+ DWORD ssl_policy_flags;
+ DWORD expected_error;
+ BOOL wine_todo;
+ }
+ tests[] =
+ {
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, 0, 0, CRYPT_E_REVOCATION_OFFLINE, TRUE },
+ /* CERT_TRUST_REVOCATION_STATUS_UNKNOWN is only cheked on the end certificate. */
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 1, 0, 0, ERROR_SUCCESS, TRUE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 2, 0, 0, ERROR_SUCCESS, TRUE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_END_REV_UNKNOWN_FLAG, 0, 0, TRUE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_CTL_SIGNER_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE, TRUE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_CA_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE, TRUE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_ROOT_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE, TRUE },
+ /* CERT_TRUST_IS_OFFLINE_REVOCATION is ignored. */
+ { CERT_TRUST_IS_OFFLINE_REVOCATION, 0, 0, 0, ERROR_SUCCESS, TRUE },
+ { CERT_TRUST_IS_OFFLINE_REVOCATION, 1, 0, 0, ERROR_SUCCESS, TRUE },
+ { CERT_TRUST_IS_OFFLINE_REVOCATION, 2, 0, 0, ERROR_SUCCESS, TRUE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 0, 0, 0, CRYPT_E_REVOCATION_OFFLINE, TRUE },
+ /* CERT_TRUST_REVOCATION_STATUS_UNKNOWN is only cheked on the end certificate. */
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 1, 0, 0, ERROR_SUCCESS },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 2, 0, 0, ERROR_SUCCESS },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 0, CERT_CHAIN_POLICY_IGNORE_END_REV_UNKNOWN_FLAG, 0, 0 },
+
+ { CERT_TRUST_IS_REVOKED, 0, 0, 0, CRYPT_E_REVOKED, TRUE },
+ { CERT_TRUST_IS_REVOKED, 1, 0, 0, CRYPT_E_REVOKED, TRUE },
+ { CERT_TRUST_IS_REVOKED, 2, 0, 0, CRYPT_E_REVOKED, TRUE },
+
+ { CERT_TRUST_IS_NOT_VALID_FOR_USAGE, 0, 0, 0, CERT_E_WRONG_USAGE },
+ { CERT_TRUST_IS_NOT_VALID_FOR_USAGE, 1, 0, 0, CERT_E_WRONG_USAGE },
+ { CERT_TRUST_IS_NOT_VALID_FOR_USAGE, 2, 0, 0, CERT_E_WRONG_USAGE },
+ { CERT_TRUST_IS_NOT_VALID_FOR_USAGE, 0, 0, SECURITY_FLAG_IGNORE_WRONG_USAGE, ERROR_SUCCESS },
+ { CERT_TRUST_IS_NOT_VALID_FOR_USAGE, 0, CERT_CHAIN_POLICY_IGNORE_WRONG_USAGE_FLAG, 0, ERROR_SUCCESS, TRUE },
+
+ { CERT_TRUST_IS_SELF_SIGNED, 0, 0, 0, TRUST_E_CERT_SIGNATURE },
+ { CERT_TRUST_IS_SELF_SIGNED, 1, 0, 0, TRUST_E_CERT_SIGNATURE },
+ { CERT_TRUST_IS_SELF_SIGNED, 2, 0, 0, TRUST_E_CERT_SIGNATURE },
+ { CERT_TRUST_IS_SELF_SIGNED, 2, 0, SECURITY_FLAG_IGNORE_UNKNOWN_CA, TRUST_E_CERT_SIGNATURE },
+ { CERT_TRUST_IS_SELF_SIGNED, 2, CERT_CHAIN_POLICY_ALLOW_UNKNOWN_CA_FLAG, 0, TRUST_E_CERT_SIGNATURE },
+ };
+
+ BOOL ret;
+ PCCERT_CONTEXT cert;
+ CERT_CHAIN_PARA para = { 0 };
+ PCCERT_CHAIN_CONTEXT chain;
+ FILETIME fileTime;
+ HCERTSTORE store;
+ static char one_two_three[] = "1.2.3";
+ LPSTR oids[1];
+ SSL_EXTRA_CERT_CHAIN_POLICY_PARA ssl_para;
+ CERT_CHAIN_POLICY_PARA policy_para;
+ CERT_CHAIN_POLICY_STATUS status;
+ CERT_REVOCATION_INFO rev_info[3];
+ //CERT_REVOCATION_CRL_INFO crl_info;
+ unsigned int i;
+
+ store = CertOpenStore(CERT_STORE_PROV_MEMORY, 0, 0, CERT_STORE_CREATE_NEW_FLAG, NULL);
+ CertAddEncodedCertificateToStore(store, X509_ASN_ENCODING, geotrust_global_ca,
+ sizeof(geotrust_global_ca), CERT_STORE_ADD_ALWAYS, NULL);
+ CertAddEncodedCertificateToStore(store, X509_ASN_ENCODING, google_internet_authority,
+ sizeof(google_internet_authority), CERT_STORE_ADD_ALWAYS, NULL);
+ cert = CertCreateCertificateContext(X509_ASN_ENCODING, google_com, sizeof(google_com));
+ SystemTimeToFileTime(&oct2009, &fileTime);
+ memset(&para, 0, sizeof(para));
+ para.cbSize = sizeof(para);
+ oids[0] = one_two_three;
+ para.RequestedUsage.dwType = USAGE_MATCH_TYPE_AND;
+ para.RequestedUsage.Usage.rgpszUsageIdentifier = oids;
+ para.RequestedUsage.Usage.cUsageIdentifier = 1;
+ ret = CertGetCertificateChain(NULL, cert, &fileTime, store, &para, CERT_CHAIN_REVOCATION_CHECK_CACHE_ONLY, NULL, &chain);
+ ok(ret, "got error %#lx.\n", GetLastError());
+ ok(chain->cChain == 1, "got %lu.\n", chain->cChain);
+ ok(chain->rgpChain[0]->cElement == 3, "got %lu.\n", chain->rgpChain[0]->cElement);
+
+ memset(&policy_para, 0, sizeof(policy_para));
+ policy_para.cbSize = sizeof(policy_para);
+ memset(&ssl_para, 0, sizeof(ssl_para));
+ ssl_para.cbSize = sizeof(ssl_para);
+ ssl_para.dwAuthType = AUTHTYPE_SERVER;
+ ssl_para.pwszServerName = (WCHAR *)L"www.google.com";
+ policy_para.pvExtraPolicyPara = &ssl_para;
+ status.cbSize = sizeof(status);
+
+ for (i = 0; i < chain->rgpChain[0]->cElement; ++i)
+ {
+ chain->rgpChain[0]->rgpElement[i]->TrustStatus.dwErrorStatus = 0;
+ memset(&rev_info[i], 0, sizeof(rev_info[i]));
+ rev_info[i].cbSize = sizeof(rev_info);
+ chain->rgpChain[0]->rgpElement[i]->pRevocationInfo = &rev_info[i];
+ }
+
+ for (i = 0; i < ARRAY_SIZE(tests); ++i)
+ {
+ winetest_push_context("test %u", i);
+ *(DWORD *)&chain->TrustStatus.dwErrorStatus = tests[i].trust_status;//CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION;//CERT_TRUST_IS_REVOKED;//CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION;
+ chain->rgpChain[0]->TrustStatus.dwErrorStatus = chain->TrustStatus.dwErrorStatus;
+ chain->rgpChain[0]->rgpElement[tests[i].index]->TrustStatus.dwErrorStatus = chain->TrustStatus.dwErrorStatus;
+ policy_para.dwFlags = tests[i].policy_flags;
+ ssl_para.cbSize = sizeof(ssl_para);
+ ssl_para.fdwChecks = tests[i].ssl_policy_flags;
+ policy_para.pvExtraPolicyPara = &ssl_para;
+ ret = CertVerifyCertificateChainPolicy(CERT_CHAIN_POLICY_SSL, chain, &policy_para, &status);
+ ok(ret, "got error %#lx.\n", GetLastError());
+ todo_wine_if(tests[i].wine_todo) ok(status.dwError == tests[i].expected_error, "got %#lx, expected %#lx.\n", status.dwError, tests[i].expected_error);
+ if (status.dwError)
+ {
+ ok(!status.lChainIndex, "got %ld.\n", status.lChainIndex);
+ ok(status.lElementIndex == tests[i].index, "got %ld.\n", status.lElementIndex);
+ }
+ else
+ {
+ ok(status.lChainIndex == -1, "got %ld.\n", status.lChainIndex);
+ ok(status.lElementIndex == -1, "got %ld.\n", status.lElementIndex);
+ }
+ chain->rgpChain[0]->rgpElement[tests[i].index]->TrustStatus.dwErrorStatus = 0;
+ winetest_pop_context();
+ }
+ for (i = 0; i < chain->rgpChain[0]->cElement; ++i)
+ chain->rgpChain[0]->rgpElement[i]->pRevocationInfo = NULL;
+
+ CertFreeCertificateChain(chain);
+ CertFreeCertificateContext(cert);
+ CertCloseStore(store, 0);
+}
+
START_TEST(chain)
{
testCreateCertChainEngine();
testVerifyCertChainPolicy();
testGetCertChain();
test_CERT_CHAIN_PARA_cbSize();
+ test_VerifyCertChainPolicy_flags();
}
--
GitLab

71 changes: 71 additions & 0 deletions ...ixes-for-verify-ssl-policy-/0002-crypt32-Fix-some-error-codes-in-verify-ssl-policy-.patch
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
From becb9b7b897141224e3bf270389d02a265d1ee67 Mon Sep 17 00:00:00 2001
From: Paul Gofman <[email protected]>
Date: Wed, 8 Jan 2025 19:23:03 -0600
Subject: [PATCH] crypt32: Fix some error codes in verify_ssl_policy().

---
dlls/crypt32/chain.c | 4 ++--
dlls/crypt32/tests/chain.c | 14 +++++++-------
2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/dlls/crypt32/chain.c b/dlls/crypt32/chain.c
index 5e4288eda37..b7072a2f8b4 100644
--- a/dlls/crypt32/chain.c
+++ b/dlls/crypt32/chain.c
@@ -3513,7 +3513,7 @@ static BOOL WINAPI verify_ssl_policy(LPCSTR szPolicyOID,
else if (pChainContext->TrustStatus.dwErrorStatus &
CERT_TRUST_IS_REVOKED && !(checks & SECURITY_FLAG_IGNORE_REVOCATION))
{
- pPolicyStatus->dwError = CERT_E_REVOKED;
+ pPolicyStatus->dwError = CRYPT_E_REVOKED;
find_element_with_error(pChainContext,
CERT_TRUST_IS_REVOKED, &pPolicyStatus->lChainIndex,
&pPolicyStatus->lElementIndex);
@@ -3522,7 +3522,7 @@ static BOOL WINAPI verify_ssl_policy(LPCSTR szPolicyOID,
CERT_TRUST_IS_OFFLINE_REVOCATION &&
!(checks & SECURITY_FLAG_IGNORE_REVOCATION))
{
- pPolicyStatus->dwError = CERT_E_REVOCATION_FAILURE;
+ pPolicyStatus->dwError = CRYPT_E_REVOCATION_OFFLINE;
find_element_with_error(pChainContext,
CERT_TRUST_IS_OFFLINE_REVOCATION, &pPolicyStatus->lChainIndex,
&pPolicyStatus->lElementIndex);
diff --git a/dlls/crypt32/tests/chain.c b/dlls/crypt32/tests/chain.c
index d198b92a31c..db3c3f36228 100644
--- a/dlls/crypt32/tests/chain.c
+++ b/dlls/crypt32/tests/chain.c
@@ -5389,14 +5389,14 @@ static void test_VerifyCertChainPolicy_flags(void)
}
tests[] =
{
- { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, 0, 0, CRYPT_E_REVOCATION_OFFLINE, TRUE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, 0, 0, CRYPT_E_REVOCATION_OFFLINE },
/* CERT_TRUST_REVOCATION_STATUS_UNKNOWN is only cheked on the end certificate. */
{ CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 1, 0, 0, ERROR_SUCCESS, TRUE },
{ CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 2, 0, 0, ERROR_SUCCESS, TRUE },
{ CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_END_REV_UNKNOWN_FLAG, 0, 0, TRUE },
- { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_CTL_SIGNER_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE, TRUE },
- { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_CA_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE, TRUE },
- { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_ROOT_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE, TRUE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_CTL_SIGNER_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_CA_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_ROOT_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE },
/* CERT_TRUST_IS_OFFLINE_REVOCATION is ignored. */
{ CERT_TRUST_IS_OFFLINE_REVOCATION, 0, 0, 0, ERROR_SUCCESS, TRUE },
{ CERT_TRUST_IS_OFFLINE_REVOCATION, 1, 0, 0, ERROR_SUCCESS, TRUE },
@@ -5407,9 +5407,9 @@ static void test_VerifyCertChainPolicy_flags(void)
{ CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 2, 0, 0, ERROR_SUCCESS },
{ CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 0, CERT_CHAIN_POLICY_IGNORE_END_REV_UNKNOWN_FLAG, 0, 0 },

- { CERT_TRUST_IS_REVOKED, 0, 0, 0, CRYPT_E_REVOKED, TRUE },
- { CERT_TRUST_IS_REVOKED, 1, 0, 0, CRYPT_E_REVOKED, TRUE },
- { CERT_TRUST_IS_REVOKED, 2, 0, 0, CRYPT_E_REVOKED, TRUE },
+ { CERT_TRUST_IS_REVOKED, 0, 0, 0, CRYPT_E_REVOKED },
+ { CERT_TRUST_IS_REVOKED, 1, 0, 0, CRYPT_E_REVOKED },
+ { CERT_TRUST_IS_REVOKED, 2, 0, 0, CRYPT_E_REVOKED },

{ CERT_TRUST_IS_NOT_VALID_FOR_USAGE, 0, 0, 0, CERT_E_WRONG_USAGE },
{ CERT_TRUST_IS_NOT_VALID_FOR_USAGE, 1, 0, 0, CERT_E_WRONG_USAGE },
--
GitLab

77 changes: 77 additions & 0 deletions ...ON-STATUS-UNKNOWN-instead-of-CERT-TRUST-IS-OFFLINE-REVOCATION-in-verify-ssl-policy-.patch
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
From a761fef2673ee8ff8dcd6017261ab0b66e3b2e0c Mon Sep 17 00:00:00 2001
From: Paul Gofman <[email protected]>
Date: Wed, 8 Jan 2025 19:32:06 -0600
Subject: [PATCH] crypt32: Check CERT_TRUST_REVOCATION_STATUS_UNKNOWN instead
of CERT_TRUST_IS_OFFLINE_REVOCATION in verify_ssl_policy().

---
dlls/crypt32/chain.c | 8 +++-----
dlls/crypt32/tests/chain.c | 14 +++++++-------
2 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/dlls/crypt32/chain.c b/dlls/crypt32/chain.c
index b7072a2f8b4..fb2f391ff6e 100644
--- a/dlls/crypt32/chain.c
+++ b/dlls/crypt32/chain.c
@@ -2707,6 +2707,7 @@ static void CRYPT_VerifyChainRevocation(PCERT_CHAIN_CONTEXT chain,

switch (revocationStatus.dwError)
{
+ case CRYPT_E_REVOCATION_OFFLINE:
case CRYPT_E_NO_REVOCATION_CHECK:
case CRYPT_E_NO_REVOCATION_DLL:
case CRYPT_E_NOT_IN_REVOCATION_DATABASE:
@@ -2716,9 +2717,6 @@ static void CRYPT_VerifyChainRevocation(PCERT_CHAIN_CONTEXT chain,
error = CERT_TRUST_REVOCATION_STATUS_UNKNOWN |
CERT_TRUST_IS_OFFLINE_REVOCATION;
break;
- case CRYPT_E_REVOCATION_OFFLINE:
- error = CERT_TRUST_IS_OFFLINE_REVOCATION;
- break;
case CRYPT_E_REVOKED:
error = CERT_TRUST_IS_REVOKED;
break;
@@ -3519,12 +3517,12 @@ static BOOL WINAPI verify_ssl_policy(LPCSTR szPolicyOID,
&pPolicyStatus->lElementIndex);
}
else if (pChainContext->TrustStatus.dwErrorStatus &
- CERT_TRUST_IS_OFFLINE_REVOCATION &&
+ CERT_TRUST_REVOCATION_STATUS_UNKNOWN &&
!(checks & SECURITY_FLAG_IGNORE_REVOCATION))
{
pPolicyStatus->dwError = CRYPT_E_REVOCATION_OFFLINE;
find_element_with_error(pChainContext,
- CERT_TRUST_IS_OFFLINE_REVOCATION, &pPolicyStatus->lChainIndex,
+ CERT_TRUST_REVOCATION_STATUS_UNKNOWN, &pPolicyStatus->lChainIndex,
&pPolicyStatus->lElementIndex);
}
else if (pChainContext->TrustStatus.dwErrorStatus &
diff --git a/dlls/crypt32/tests/chain.c b/dlls/crypt32/tests/chain.c
index db3c3f36228..f4f5a69698f 100644
--- a/dlls/crypt32/tests/chain.c
+++ b/dlls/crypt32/tests/chain.c
@@ -5398,14 +5398,14 @@ static void test_VerifyCertChainPolicy_flags(void)
{ CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_CA_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE },
{ CERT_TRUST_REVOCATION_STATUS_UNKNOWN | CERT_TRUST_IS_OFFLINE_REVOCATION, 0, CERT_CHAIN_POLICY_IGNORE_ROOT_REV_UNKNOWN_FLAG, 0, CRYPT_E_REVOCATION_OFFLINE },
/* CERT_TRUST_IS_OFFLINE_REVOCATION is ignored. */
- { CERT_TRUST_IS_OFFLINE_REVOCATION, 0, 0, 0, ERROR_SUCCESS, TRUE },
- { CERT_TRUST_IS_OFFLINE_REVOCATION, 1, 0, 0, ERROR_SUCCESS, TRUE },
- { CERT_TRUST_IS_OFFLINE_REVOCATION, 2, 0, 0, ERROR_SUCCESS, TRUE },
- { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 0, 0, 0, CRYPT_E_REVOCATION_OFFLINE, TRUE },
+ { CERT_TRUST_IS_OFFLINE_REVOCATION, 0, 0, 0, ERROR_SUCCESS },
+ { CERT_TRUST_IS_OFFLINE_REVOCATION, 1, 0, 0, ERROR_SUCCESS },
+ { CERT_TRUST_IS_OFFLINE_REVOCATION, 2, 0, 0, ERROR_SUCCESS },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 0, 0, 0, CRYPT_E_REVOCATION_OFFLINE },
/* CERT_TRUST_REVOCATION_STATUS_UNKNOWN is only cheked on the end certificate. */
- { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 1, 0, 0, ERROR_SUCCESS },
- { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 2, 0, 0, ERROR_SUCCESS },
- { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 0, CERT_CHAIN_POLICY_IGNORE_END_REV_UNKNOWN_FLAG, 0, 0 },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 1, 0, 0, ERROR_SUCCESS, TRUE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 2, 0, 0, ERROR_SUCCESS, TRUE },
+ { CERT_TRUST_REVOCATION_STATUS_UNKNOWN, 0, CERT_CHAIN_POLICY_IGNORE_END_REV_UNKNOWN_FLAG, 0, 0, TRUE },

{ CERT_TRUST_IS_REVOKED, 0, 0, 0, CRYPT_E_REVOKED },
{ CERT_TRUST_IS_REVOKED, 1, 0, 0, CRYPT_E_REVOKED },
--
GitLab

Loading

0 comments on commit d4a6672

Please sign in to comment.