Skip to content

added the $maxPerPage and $currentPage params to the constructor#198

Open
yjv wants to merge 2 commits into
whiteoctober:masterfrom
giftcards:add-page-and-max-per-page-to-constructor
Open

added the $maxPerPage and $currentPage params to the constructor#198
yjv wants to merge 2 commits into
whiteoctober:masterfrom
giftcards:add-page-and-max-per-page-to-constructor

Conversation

@yjv

@yjv yjv commented Jan 18, 2016

Copy link
Copy Markdown

this allows you the instaciate the PagerFanta instance all ready to go if you are already on a different page or you want a different max per page

@stof

stof commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

This misses the validation of the values which is applied by setters.

and this is also missing tests covering this API

@Koc

Koc commented Nov 27, 2017

Copy link
Copy Markdown

now checks added. Can we merge? @sampart @stof

@sampart

sampart commented Nov 27, 2017

Copy link
Copy Markdown
Collaborator

@Koc Thanks for this. I can see that you've switched to using the setters which is great, but I think you still need to add tests as @stof mentioned please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants