fix: retry transient HTTP errors (502/503/504/429) during session polling#55
Open
peterfoldes wants to merge 2 commits intomainfrom
Open
fix: retry transient HTTP errors (502/503/504/429) during session polling#55peterfoldes wants to merge 2 commits intomainfrom
peterfoldes wants to merge 2 commits intomainfrom
Conversation
…ling The session status polling retry logic treated all requests.HTTPError as non-retryable, causing transient errors like 502 Bad Gateway to immediately fail the connection instead of retrying. This changes the retry strategy to use tenacity's composable retry_if_exception predicate to distinguish transient HTTP errors (429, 502, 503, 504) from permanent ones (401, 403, 404), matching the industry-standard status_forcelist from urllib3.util.Retry.
peterfoldes
requested review from
ClayMav,
mpetazzoni and
zongsizhang
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The session status polling retry logic treated all
requests.HTTPErroras non-retryable, causing transient errors like 502 Bad Gateway to immediately fail the connection instead of retrying within the 15-minute wait window. This uses tenacity's composableretry_if_exceptionpredicate to retry on transient HTTP status codes (429, 502, 503, 504) while still failing immediately on permanent errors (401, 403, 404, etc.).Related Issues
Observed in Airflow canary tests for
aws-ap-south-1where a 502 during session polling immediately killed the task.Requester Checklist
Complete these before marking Ready for Review