[WIP] Multithreading fixes #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheremyfoodat
commented
Jul 28, 2023
src/core/kernel/events.cpp
Outdated
| @@ -48,7 +48,7 @@ bool Kernel::signalEvent(Handle handle) { | |||
| // We must reschedule our threads if we signalled one. Some games such as FE: Awakening rely on this | |||
| // If this does not happen, we can have phenomena such as a thread waiting up a higher priority thread, | |||
| // and the higher priority thread just never running | |||
| rescheduleThreads(); | |||
| requireReschedule(); | |||
There was a problem hiding this comment.
I am not sure if this should happen.
Also need to investigate how OneShot events work a bit better
wheremyfoodat
commented
Jul 28, 2023
| @@ -121,7 +121,6 @@ void Kernel::waitSynchronization1() { | |||
| if (!shouldWaitOnObject(object)) { | |||
| acquireSyncObject(object, threads[currentThreadIndex]); // Acquire the object since it's ready | |||
| regs[0] = Result::Success; | |||
| rescheduleThreads(); | |||
There was a problem hiding this comment.
This may or may not need to request a reschedule, still
wheremyfoodat
commented
Jul 28, 2023
| if (!waitAll) { | ||
| // If there's ready objects, acquire the first one and return | ||
| if (oneObjectReady) { | ||
| regs[0] = Result::Success; | ||
| regs[1] = firstReadyObjectIndex; // Return index of the acquired object | ||
| acquireSyncObject(waitObjects[firstReadyObjectIndex].second, t); // Acquire object | ||
| rescheduleThreads(); |
There was a problem hiding this comment.
Ditto from WaitSync1
|
Note: some of the games above need my local "Sleep thread on SendSyncRequest" as well |
wheremyfoodat
force-pushed
the
panda-kith
branch
2 times, most recently
from
2ae08e3 to
57c3224
Compare
wheremyfoodat
force-pushed
the
panda-kith
branch
from
222d0a3 to
60de6a6
Compare
|
(This code will likely be revisited soon but might as well merge it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes to the thread scheduler. Fixes or improves a bunch of games including the following
This is still WIP and won't be merged until all regressions are fixed and some stubborn games are fixed
Partially covers #124