New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one loop index #186

Merged

annevk merged 1 commit into whatwg:main from jyavenard:bug_184

Mar 25, 2024

Member

jyavenard commented Mar 19, 2024 •

edited by pr-preview bot

Loading

(fixes #184)

Tests are written and can be reviewed and commented upon at:
- No need for new tests, the wpt already use the proper algorithm.

(See WHATWG Working Mode: Changes for more details.)


          Fix off-by-one loop index

c3b7103

(fixes whatwg#184)

Member

annevk commented Mar 19, 2024

@padenot can you help review?

Collaborator

padenot commented Mar 19, 2024

Looks good, sorry for the mistake in the first place.

annevk merged commit 975191b into whatwg:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet