Editorial: replace uses of the Type macro with is-a tests #10635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thank you! But, would you be willing to make these links, like they are in ecma262? |
|
This will need to be done for at least Streams as well, possibly other specs too. |
|
Good point. Web IDL is the big one. (In theory Streams should be using more Web IDL to abstract away ES details; in practice it hasn't been updated yet.) |
michaelficarra
force-pushed
the
ecma262-type-tests
branch
from
42444f4 to
76079f8
Compare
|
@domenic I've added links. I'm not sure if you want undefined/null linked. I linked things in the way they are linked in ECMA-262, so no link for undefined/null and linking the whole text "is not an Object", etc. |
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of tc39/ecma262#2874 (September 2022), ecma262 no longer uses the Type macro for simple type tests. We have replaced them with "x is a Y"-style notation. We also replaced most of the remaining uses of the Type macro with the new SameType AO in tc39/ecma262#3408. It wasn't a problem that HTML continued to use the old-style Type checks until tc39/ecma262#3420 which removes the final use of the Type macro and with it the Type macro itself.
This is the HTML integration, updating the type tests to the new form and allowing us to un-define the Type macro in ecma262.
/cc @syg @bakkot
/acknowledgements.html ( diff )
/canvas.html ( diff )
/custom-elements.html ( diff )
/dom.html ( diff )
/infrastructure.html ( diff )
/structured-data.html ( diff )