Meta: Do not tag release without public changes #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a refactoring of our GitHub actions. The tag workflow and script have been removed completely, since the release action will implicitly create the release tag if it does not exit, yet. This makes sure that we do not create a tag when there will be no release. We have only one workflow now, which contains two jobs: one for generating the changelog and one for creating the release. The changelog job will generate the changelog and upload it as an artifact if there are public changes. The release version, which previously was determined in the tag script, is now determined within this job, so that we can pass it to the release job. The release job will run only if the changelog job was successful, i.e. if there are public changes. It will create a tag and a GitHub release with the given version number. The workflow will run on the first day of every month for our regular automatic monthly releases. It will also run on every tag push, so that we still can create a release manually if necessary. The release action will implicitly use the existing tag for the release then. Fixes wfxr#413 Closes wfxr#414
|
FYI: I have tested this new workflow in my fork of the repo. |
cjappl
reviewed
Mar 12, 2025
sandr01d
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Should do what we want and looks very readable to me. Well done, @carlfriedrich!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a refactoring of our GitHub actions. The tag workflow and script have been removed completely, since the release action will implicitly create the release tag if it does not exit, yet. This makes sure that we do not create a tag when there will be no release.
We have only one workflow now, which contains two jobs: one for generating the changelog and one for creating the release.
The changelog job will generate the changelog and upload it as an artifact if there are public changes. The release version, which previously was determined in the tag script, is now determined within this job, so that we can pass it to the release job.
The release job will run only if the changelog job was successful, i.e. if there are public changes. It will create a tag and a GitHub release with the given version number.
The workflow will run on the first day of every month for our regular automatic monthly releases.
It will also run on every tag push, so that we still can create a release manually if necessary. The release action will implicitly use the existing tag for the release then.
Fixes #413
Closes #414
Check list
Description
Type of change
Test environment