Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.9.0 #262

Merged
merged 4 commits into from
Jan 18, 2019
Merged

Release v0.9.0 #262

merged 4 commits into from
Jan 18, 2019

Conversation

philsturgeon
Copy link
Contributor

@philsturgeon philsturgeon commented Jan 18, 2019

The mega PR #248 changed so much it deserves its own release. The development version v0.9.0-1 has already been tagged for testing, and seems to be working.

Breaking

  • The lib/linter.js module has been entirely removed, and oas-linter is now used directly (#248)
  • Rulesets must now be YAML not JSON (#248)

Fixed

  • Response mime types with a + (e.g: application/vnd.api+json) are now encoded correctly (#248)
  • The lint option --skip and the matching config option are no longer being ignored

@coveralls
Copy link

coveralls commented Jan 18, 2019

Coverage Status

Coverage remained the same at 84.42% when pulling a2c91c7 on release/0.9.0 into c826b76 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.42% when pulling 06fbdb5 on release/0.9.0 into c826b76 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.42% when pulling 06fbdb5 on release/0.9.0 into c826b76 on master.

@MikeRalphson
Copy link
Contributor

@philsturgeon JSON is a subset of YAML, so you can still write (and read) rulesets in JSON, making it not a breaking change.

@philsturgeon
Copy link
Contributor Author

Ahh yeah, and seeing as the extension is not enforced it doesn't matter! I'll update, thank you.


<hr>

### Creating Rule Actions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeRalphson do you have docs for creating rule actions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean like a CONTRIBUTING.md or a section in https://github.com/Mermade/oas-kit/blob/master/docs/linter-rules.md? Hmm, not yet, but it's a good idea, so I've opened a tracking issue Mermade/oas-kit#144

@philsturgeon philsturgeon merged commit 85efdbd into master Jan 18, 2019
@philsturgeon philsturgeon deleted the release/0.9.0 branch January 18, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants