fix: websocket reconnection loop #3805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3804
Observations before the PR
reconnectCountis incremented inside thesetTimeout, so ifonCloseoronErroris triggered before the timeout it will schedule another reconnect with the "old"reconnectCountvalueonErrorandonClosemay both callsetupat the same time, leading to multiple socketsonErrorcloses the entiresocketClient, which removes thesocketClientfrom thesocketClientCache, so the next time a socket client is requested, a fresh client is created (which also resets thereconnectCount). There is no limit to reconnection attempts or cooldown in this scenario.Behavior before this change
CleanShot.2025-07-16.at.15.49.31.mp4
Changes implemented in this PR
onCloseandonErrorare triggered shortly after each other)socket, not the wholesocketClientin reaction to an error, so we can still attempt a reconnect (without this the reconnection limit is not respected)socketinstance on reconnect to make sure there is only one open instance at a time. (This could also be moved back toonErrorsince the socket should already be closed inonClose, but I find it easier to reason about if it's located with the reconnection logic. Not a strong opinion.)Behavior with these changes
CleanShot.2025-07-16.at.17.32.57.mp4