Add new pipeline 2025-03-6 #2846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
StepanBrychta
force-pushed
the
Add-pipeline-2025-03-06
branch
from
b78d6d3 to
f1ada4b
Compare
|
Approved for reindex 👍 |
kenoir
force-pushed
the
Add-pipeline-2025-03-06
branch
from
f1ada4b to
9689608
Compare
kenoir
force-pushed
the
Add-pipeline-2025-03-06
branch
from
9689608 to
0a4a359
Compare
StepanBrychta
commented
Mar 10, 2025
| @@ -52,7 +52,7 @@ module "id_minter_lambda" { | |||
| queue_config = { | |||
| topic_arns = local.transformer_output_topic_arns | |||
| max_receive_count = 3 | |||
| maximum_concurrency = 10 | |||
| maximum_concurrency = 30 | |||
There was a problem hiding this comment.
When the ID minter concurrency is set to 10, it becomes a bottleneck during a reindex. Increasing the concurrency to 30 helps, without overwhelming the database.
kenoir
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
#5912
Following on wellcomecollection/platform#5911.
How to test
How can we measure success?
After reindexing with the new pipeline, all concepts which reference the same source concept or have the same labels (for label-derived concepts) should have the same canonical id.
Have we considered potential risks?
Risks should be minimal.