Skip to content
This repository was archived by the owner on Jun 10, 2022. It is now read-only.

Choose partition by key for several brokers #208

Closed
wants to merge 11 commits into from
Closed

Choose partition by key for several brokers #208

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ae7ff78
Choose partition by key for several brokers
May 8, 2018
08478d3
Choose partition by key for several brokers
May 10, 2018
5050dfb
Choose partition by key for several brokers
May 10, 2018
89b7fff
Мoved the logic of the choice of partitions to the broker method and …
May 10, 2018
136b1f7
Мoved the logic of the choice of partitions to the broker method and …
May 10, 2018
ab67b89
Мoved the logic of the choice of partitions to the broker method and …
May 10, 2018
d359041
Мoved the logic of the choice of partitions to the broker method and …
May 10, 2018
984d51e
Мoved the logic of the choice of partitions to the broker method and …
May 10, 2018
57fc979
Мoved the logic of the choice of partitions to the broker method and …
May 10, 2018
d334465
Code quality test
May 10, 2018
b59ef25
Code quality test
May 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/Producer/SyncProcess.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,15 @@ protected function convertMessage($data)

$topicMeta = $topicInfos[$value['topic']];
$partNums = array_keys($topicMeta);
shuffle($partNums);
$partId = 0;
if (! isset($value['partId']) || ! isset($topicMeta[$value['partId']])) {
$partId = $partNums[0];
if (isset($value['key']) && trim($value['key'])) {
Copy link
Contributor

@lcobucci lcobucci May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracting this logic to a method and using early returns will make things way easier to understand, could you please do that?

$partId = crc32($value['key']) % count($partNums);
} else {
$partId = $value['partId'];
shuffle($partNums);
Copy link
Contributor

@lcobucci lcobucci May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the shuffle needed only for when you're using $partsNum?

if (! isset($value['partId']) || ! isset($topicMeta[$value['partId']])) {
$partId = $partNums[0];
} else {
$partId = $value['partId'];
}
}

$brokerId = $topicMeta[$partId];
Expand Down