fix: flex container size should add gap size if gap is defined#30
Merged
fix: flex container size should add gap size if gap is defined#30
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the flexbox layout algorithm where flex container sizes were not including gap sizes in their calculations. The fix ensures that when computing the final size of a flex container, both main-axis and cross-axis gaps between flex items are properly accounted for.
Key changes:
- Added
total_gapfield toFlexLinestruct to cache the calculated gap for each line - Updated container size calculations to include gap sizes for both main and cross axes
- Refactored code to avoid duplicate gap calculations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
float-pigment-layout/src/algo/flex_box.rs |
Adds total_gap field to FlexLine struct, calculates and caches gap values, and includes gaps in all container size computations (main axis, cross axis, and free space calculations) |
float-pigment-forest/tests/custom/css_flexbox/gap.rs |
Adds test case validating that flex items correctly shrink when gaps are present and container has a fixed size |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.