Rename fallible constructors to use try prefix#106
Open
lndmrk wants to merge 1 commit intowebrtc:mainfrom
Open
Rename fallible constructors to use try prefix#106lndmrk wants to merge 1 commit intowebrtc:mainfrom
lndmrk wants to merge 1 commit intowebrtc:mainfrom
Conversation
This makes it easier to understand which initializations can fail at the call site.
boivie
reviewed
Mar 20, 2026
| .events | ||
| .borrow_mut() | ||
| .add(SocketEvent::OnError(ErrorKind::ParseFailed, s.into())); | ||
| .add(SocketEvent::OnError(ErrorKind::ParseFailed, s.to_string())); |
Collaborator
There was a problem hiding this comment.
from into() to to_string() is a bit unrelated to the rest of this commit, and to_string() isn't necessarily the same (it happens to be for this type), as it uses the Display trait. It's fine in this case, though.
boivie
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to understand which initializations can fail at the call site.