Skip to content

refactor(ice): replace magic numbers with named constants for STUN/TURN ports #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(ice): replace magic numbers with named constants for STUN/TURN ports #697

wants to merge 1 commit into from

Conversation

cppcoffee
Copy link
Contributor

Replace hardcoded port numbers 3478 and 5349 with DEFAULT_PORT and
DEFAULT_TLS_PORT constants from the stun module to improve code
readability and maintainability.

  • Add import for stun::{DEFAULT_PORT, DEFAULT_TLS_PORT}
  • Replace 3478 with DEFAULT_PORT for STUN/TURN protocols
  • Replace 5349 with DEFAULT_TLS_PORT for STUNS/TURNS protocols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cppcoffee